Feat/talking about - #682
Merged
Merged
Conversation
Adds /docs/featured/articles as the written-content counterpart to the YouTube page: an aggregator of community articles about Zard UI, with the original cover image of each post and a submission section pointing to the same address used for video submissions. Seeded with the two dev.to articles currently available. Adding a new one is a single entry in featured-articles.ts.
Featured lists community content, not API reference, so sitting between Get Started and Components broke the reading order of the sidebar. It now comes last, after Contribute. SIDEBAR_PATHS backs the sidebar, the mobile menu, the command palette and the sitemap, so all four follow the new order. Prerendered routes are unaffected.
📝 WalkthroughWalkthroughAdds a Featured Articles page with article data, grouped rendering, scroll-spy navigation, SEO metadata, cover-image fallback handling, tests, lazy routing, sidebar integration, and prerendering. ChangesFeatured articles
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Sidebar
participant AngularRouter
participant ArticlesPage
participant ArticlesPageTemplate
Sidebar->>AngularRouter: Navigate to /docs/featured/articles
AngularRouter->>ArticlesPage: Lazy-load page component
ArticlesPage->>ArticlesPageTemplate: Render grouped article data
ArticlesPageTemplate->>ArticlesPage: Report failed cover image
ArticlesPage->>ArticlesPageTemplate: Render placeholder cover
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/app/domain/pages/featured/articles/articles.page.html`:
- Around line 40-46: Update the cover image in the article link to use an empty
alt value instead of including article.title, while leaving the adjacent h3
heading and other image attributes unchanged.
In `@apps/web/src/app/domain/pages/featured/articles/articles.page.ts`:
- Around line 35-51: Update the articles page component metadata by importing
ViewEncapsulation from `@angular/core` and setting encapsulation to
ViewEncapsulation.None in the `@Component` decorator.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 50ee69bb-c4b0-4672-828e-1c84a1bbcf08
⛔ Files ignored due to path filters (2)
apps/web/public/docs/featured/articles.mdis excluded by!apps/web/public/**and included byapps/**carousel-upgrade.mdis excluded by none and included by none
📒 Files selected for processing (7)
apps/web/prerender-routes.txtapps/web/src/app/domain/pages/featured/articles/articles.page.htmlapps/web/src/app/domain/pages/featured/articles/articles.page.spec.tsapps/web/src/app/domain/pages/featured/articles/articles.page.tsapps/web/src/app/domain/pages/featured/data/featured-articles.tsapps/web/src/app/domain/pages/featured/featured.routes.tsapps/web/src/app/shared/constants/routes.constant.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done? 📝
adding all the articles I found on the internet about Zard
Screenshots or GIFs 📸
Type of change 🏗
Checklist 🧐
Summary by CodeRabbit
New Features
Bug Fixes