Skip to content

Fix typing in a bunch of store tests #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 13, 2025
Merged

Fix typing in a bunch of store tests #3052

merged 7 commits into from
May 13, 2025

Conversation

dstansby
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 10, 2025
@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label May 10, 2025
d-v-b
d-v-b requested changes May 13, 2025
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit otherwise this look good

@dstansby @d-v-b
Remove walrus
ee9dd9f 
Co-authored-by: Davis Bennett <[email protected]>
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 13, 2025
@d-v-b d-v-b enabled auto-merge (squash) May 13, 2025 10:34
@d-v-b d-v-b merged commit 7584b96 into zarr-developers:main May 13, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @d-v-b