Skip to content

obstore implementations for .getsize and .getsize_prefix #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

slowjazz
Copy link

@slowjazz slowjazz commented Jul 10, 2025

closes #3218

  • implement .getsize and .getsize_prefix for ObjectStore
  • replace the type ListStream[list[ObjectMeta]] with ListStream[Sequence[ObjectMeta]] - this appears problematic with obstore 0.7.0 and mypy.
  • minor refactor to existing implementations of .list and .list_prefix in ObjectStore.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 10, 2025
@slowjazz slowjazz marked this pull request as ready for review July 10, 2025 17:40
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (bbdefac) to head (38aa2eb).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   94.47%   94.76%   +0.28%     
==========================================
  Files          78       78              
  Lines        8604     8647      +43     
==========================================
+ Hits         8129     8194      +65     
+ Misses        475      453      -22     
Files with missing lines Coverage Δ
src/zarr/storage/_obstore.py 93.83% <100.00%> (-0.34%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override Store.getsize() for ObjectStore
1 participant