-
-
Notifications
You must be signed in to change notification settings - Fork 346
Remove outdated v3 release announcement bullet from release notes #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated v3 release announcement bullet from release notes #3235
Conversation
resolving #3208 requires removing the actual banner. this PR removes the line in the changelog that announces the addition of the banner. We don't want to change the changelog. |
@d-v-b This fully addresses the feedback about not just removing the bullet point but removing the active banner itself. Please take a look when you get a chance, happy to make any further tweaks if needed. Thanks for the guidance! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 78 78
Lines 8690 8690
=======================================
Hits 8223 8223
Misses 467 467 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - looks good, but we don't want to lose the old changelog entry.
docs/release-notes.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove this change - we want to keep the old changelog entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve restored the changelog entry as requested and confirmed the banner removal as discussed.
All changes are now in sync with the main branch, ready for your review!
Please let me know if there’s anything else you’d like adjusted.
Thanks for the feedback and guidance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Fixes #3208
This PR removes the outdated v3 release announcement bullet point from the release notes.
No code changes were made — so unit tests, API docs, and coverage do not apply.
TODO:
docs/user-guide/*.rst
(N/A)changes/
(N/A)