Skip to content

add a section showing the parse_data_type function #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 15, 2025

shows how to convert dtype-like input to a ZDType.

cc @TomNicholas

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 15, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 15, 2025

addresses part of #3247

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. My only comment is that this information could also be in the docstring of the parse_data_type function, and that that docstring should include the word "native" somewhere so it's easier to find.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 15, 2025
@d-v-b d-v-b requested a review from a team July 16, 2025 08:40
@d-v-b d-v-b enabled auto-merge (squash) July 16, 2025 13:19
@d-v-b d-v-b merged commit 18f41d4 into zarr-developers:main Jul 16, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants