-
-
Notifications
You must be signed in to change notification settings - Fork 346
make zdtype abstract methods raise notimplementederror #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make zdtype abstract methods raise notimplementederror #3251
Conversation
partially addresses #3247 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 78 78
Lines 8690 8696 +6
=======================================
+ Hits 8223 8229 +6
Misses 467 467
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed a couple of methods, specifically _from_json_v2
and _from_json_v3
good catch, I added these in f7978d9 |
[Description of PR]
TODO:
docs/user-guide/*.rst
changes/