Skip to content

make zdtype abstract methods raise notimplementederror #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2025

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 15, 2025

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 15, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 15, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 15, 2025

partially addresses #3247

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (18f41d4) to head (f7978d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3251   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          78       78           
  Lines        8690     8696    +6     
=======================================
+ Hits         8223     8229    +6     
  Misses        467      467           
Files with missing lines Coverage Δ
src/zarr/core/dtype/wrapper.py 97.87% <100.00%> (+0.31%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b requested a review from a team July 16, 2025 08:40
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a couple of methods, specifically _from_json_v2 and _from_json_v3

@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 16, 2025

I think you missed a couple of methods, specifically _from_json_v2 and _from_json_v3

good catch, I added these in f7978d9

@d-v-b d-v-b requested a review from dstansby July 16, 2025 15:39
@dstansby dstansby added this to the 3.1.1 milestone Jul 16, 2025
@dstansby dstansby merged commit 9969a5d into zarr-developers:main Jul 16, 2025
30 checks passed
@d-v-b d-v-b deleted the abstractify-zdtype-method branch July 16, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants