Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently #3406 was a bit of a tangle where
group()
andcreate_group()
had different behaviour - this was fixed by makinggroup()
a simple wrapper ofcreate_group()
, as intended.To reduce this API surface, this PR deprecates
group()
, advising users to use eithercreate_group()
oropen_group()
. The intent of these other functions is clearer, and it mirrors the methods on theGroup
class, which does not have agroup()
method.I left in one test that uses
group()
to make sure it still works during the deprecation period.TODO:
docs/user-guide/*.rst
changes/