Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: Use marker icon instead of information for generic POIs #967

Merged
merged 1 commit into from
Mar 9, 2025
+8 −8
Merged

Icons: Use marker icon instead of information for generic POIs #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
Icons: Use "marker" icon instead of "information" for generic POIs 
(when searching via overpass)

Closed: #966
@amenk
amenk committed Mar 9, 2025
commit 3449f4d7be107f0d6ebc3d2ff809bf4b9a0db584
6 changes: 3 additions & 3 deletions src/services/__tests__/fetchCrags.test.ts
View file
Original file line number Diff line number Diff line change
@@ -106,7 +106,7 @@ const geojson = [
id: 2221,
osmMeta: { id: 222, type: 'way' },
properties: {
class: 'information',
class: 'marker',
osmappType: 'way',
osmappHasImages: false,
osmappLabel: '',
@@ -203,7 +203,7 @@ test('conversion with centers instead of geometries', () => {
type: 'GeometryCollection',
},
properties: {
class: 'information',
class: 'marker',
osmappType: 'relation',
osmappHasImages: false,
osmappLabel: '',
@@ -218,7 +218,7 @@ test('conversion with centers instead of geometries', () => {
center: [14, 51],
geometry: { coordinates: [14, 51], type: 'Point' },
properties: {
class: 'information',
class: 'marker',
osmappType: 'relation',
osmappHasImages: false,
osmappLabel: '',
4 changes: 2 additions & 2 deletions src/services/__tests__/overpassAroundToSkeletons.test.ts
View file
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ const skeletons = [
type: 'node',
},
properties: {
class: 'information',
class: 'marker',
},
tags: {},
type: 'Feature',
@@ -121,7 +121,7 @@ const skeletons = [
type: 'node',
},
properties: {
class: 'information',
class: 'marker',
subclass: 'crossing',
},
tags: {
4 changes: 2 additions & 2 deletions src/services/__tests__/overpassSearch.test.ts
View file
Original file line number Diff line number Diff line change
@@ -109,7 +109,7 @@ const geojson = [
type: 'node',
},
properties: {
class: 'information',
class: 'marker',
crossing: 'marked',
highway: 'crossing',
osmappType: 'node',
@@ -137,7 +137,7 @@ const geojson = [
type: 'way',
},
properties: {
class: 'information',
class: 'marker',
highway: 'track',
osmappType: 'way',
subclass: 'track',
2 changes: 1 addition & 1 deletion src/services/getPoiClass.ts
View file
Original file line number Diff line number Diff line change
@@ -322,5 +322,5 @@ export const getPoiClass = (tags: FeatureTags): PoiClass => {
};
}

return { class: 'information', subclass }; // default icon
return { class: 'marker', subclass }; // default icon
};