Skip to content

Conversation

@mohin-io
Copy link
Contributor

@mohin-io mohin-io commented Oct 22, 2025

Overview

  • Extend the LSP metadata we propagate to guests (including WSL) so ServerInfo shows the server binary, configuration, and workspace folders instead of "Unknown".
  • Added a LanguageServerBinary proto payload, expanded LanguageServer/ServerMetadataUpdated, and taught the LSP store to capture those fields for remote servers so the log viewer can display them.

Design Decisions

  • Reused the existing metadata broadcasts (StartLanguageServer + ServerMetadataUpdated) so host and guests stay in sync without new RPCs.
  • Store the remote metadata alongside existing LanguageServerStatus entries and surface it in the log view fallback when the server isn’t running locally.
  • Left the database-backed collab metadata as optional defaults (None/empty) to avoid schema changes while still compiling with the new proto shape.

Testing

  • Not run (Rust toolchain/cargo is unavailable in this environment).

Fixes #39582.

Release Notes:

  • Show remote language server metadata (binary, configuration, workspace folders) in Server Info for guests.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 22, 2025
@maxdeviant maxdeviant changed the title lsp: surface remote server info lsp: Surface remote server info Oct 22, 2025
@SomeoneToIgnore SomeoneToIgnore self-assigned this Oct 27, 2025
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not run (Rust toolchain/cargo is unavailable in this environment).

Sorry, this looks very odd (same as the errors in CI).
There's always a possibility to do cargo run ssh://127.0.0.1/~/work/ec4rs -- --foreground and test the things locally.

Please, add some screenshots how does this look like in such test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote servers' LSP ServerInfo shows "Unknown" for Binary and Configuration

2 participants