Skip to content

feat: close all unpinned tabs in active workspace #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mr-cheffy merged 29 commits into from
Oct 28, 2025
Merged

feat: close all unpinned tabs in active workspace #10739

mr-cheffy merged 29 commits into from
Oct 28, 2025

Conversation

@santhosh-chinnasamy
Copy link
Contributor

@santhosh-chinnasamy santhosh-chinnasamy commented Oct 8, 2025 •
edited
Loading

addresses #8189

  • add keyboard shortcut to clear unpinned tabs (cmd + shift + k)
  • shows a prompt before closing tabs
  • add a clear button after pinned tab section
  • add tests if possible
Screen.Recording.2025-10-12.at.9.06.31.PM.mov

@BrixsterPlanet
Copy link

BrixsterPlanet commented Oct 8, 2025 •
edited
Loading

Wanted to also bring to your attention a tangent but not directly related request for a future PR; there should also be an auto close feature where tabs "decay" after a certain amount of time like they do in Arc (141 upvotes in #2326 but it seems to have been ignored or lost)

Thanks for this, BTW. This feature is super needed for Zen to have that maximum level of utility for tab wizards

@mr-cheffy
Copy link
Member

mr-cheffy commented Oct 8, 2025 •
edited
Loading

I don't think this interferes with any current shortcuts, am I wrong? Also, I dont think there should be a prompt for it. I believe showing a toast saying "Tabs Cleared! to restore"

@santhosh-chinnasamy
Copy link
Contributor Author

santhosh-chinnasamy commented Oct 9, 2025

I don't think this interferes with any current shortcuts, am I wrong?

Yes @mr-cheffy, this is not interfering with current shortcuts.

@mr-cheffy
Copy link
Member

mr-cheffy commented Oct 10, 2025

add a clear button after pinned tab section

Really hyped about this feature, please let me know if you have any questions on how to implement this or, if you are on discord, you can create a thread in #development and I can assist there!

@santhosh-chinnasamy
Copy link
Contributor Author

santhosh-chinnasamy commented Oct 10, 2025

Really hyped about this feature, please let me know if you have any questions on how to implement this or, if you are on discord, you can create a thread in #development and I can assist there!

Done with the implementation of close tabs button. Will add a video recording tomorrow. Meanwhile you can review the code and provide suggestions. I'll move the duplicate tab counter function to common file.

I might need help in adding tests for this feature. I'm on discord, will create a thread.

mr-cheffy
mr-cheffy requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@mr-cheffy mr-cheffy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well done! Some things I would change for the perfect PR:

We also need to figure out what to do with icons only toolbar. I'd just hide it always until we find a solution to it (icon only maybe?)

@Eatham532
Copy link

Eatham532 commented Oct 11, 2025

We also need to figure out what to do with icons only toolbar. I'd just hide it always until we find a solution to it (icon only maybe?)

At the minimum maybe add a button to the context menu?

mr-cheffy and others added 14 commits October 12, 2025 21:01
@mr-cheffy @santhosh-chinnasamy
feat: Fix bootstraping and other small nitpicks, b=no-bug, c=common, …
4113fe4 
…tabs, workspaces
@reizumii @santhosh-chinnasamy
feat: improve the site popup ui, p=zen-browser#10765
d895a48 
* style: improve site popup top buttons

* feat: add filled icons for permissions

* style: align and resize items in the site popup

* feat: site popup ui improvements and more permission icons
@mr-cheffy @santhosh-chinnasamy
chore: Better organize preferences files, b=no-bug, c=compact-mode, f…
381a29f 
…olders, glance, kbs, media, mods, split-view, welcome, workspaces
@reizumii @santhosh-chinnasamy
feat: improve the site popup ui (part 2), p=zen-browser#10768
0903aad
@mr-cheffy @santhosh-chinnasamy
feat: Add a bounce to the glance element float and format, b=no-bug, …
ba36210 
…c=common, glance
@mr-cheffy @santhosh-chinnasamy
chore: Update workflows to use macos 26 SDK, b=no-bug, c=workflows
c0b4a13
@mr-cheffy @santhosh-chinnasamy
New Crowdin updates, p=zen-browser#10769
e04af9f 
* New translations zen-preferences.ftl (French)

* New translations zen-preferences.ftl (Lithuanian)

* New translations zen-workspaces.ftl (Lithuanian)

* New translations zen-general.ftl (Lithuanian)
@santhosh-chinnasamy
list shortcut in settings page, refactor code based on PR review
447a422
@santhosh-chinnasamy
feat: show restore tabs shortcut in toast message
afaf94c
@mr-cheffy @santhosh-chinnasamy
feat: Add toggle compact mode to the default placements, b=no-bug, c=…
16037f5 
…common, glance
@mr-cheffy @santhosh-chinnasamy
chore: Only run autopep8 if python files changed, b=no-bug, c=workflows
769a6d9
@mr-cheffy @santhosh-chinnasamy
chore: Revert to the new folder animation, p=zen-browser#10783, c=fol…
54d1761 
…ders
@mr-cheffy @santhosh-chinnasamy
feat: Use close icon for pinned reset if the preference says so, p=ze…
2a074ae 
…n-browser#10786, c=no-component
@mr-cheffy @santhosh-chinnasamy
feat: Improve glance animation, p=zen-browser#10790, c=glance
2a65ed1
@santhosh-chinnasamy santhosh-chinnasamy changed the title feat: close all unpinned tabs feat: close all unpinned tabs in active workspace Oct 12, 2025
mr-cheffy
mr-cheffy requested changes Oct 12, 2025
View reviewed changes
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styling / UI is a bit off, i'll do that and merge this PR once im done with the release for this Tuesday.

@mr-cheffy
Copy link
Member

mr-cheffy commented Oct 15, 2025

@santhosh-chinnasamy i've updated this branch with the commit that fixes tests not running correctly 👍🏽

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 28, 2025

This comment was marked as resolved.

Sign in to view

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2025
@mr-cheffy mr-cheffy merged commit c21f927 into zen-browser:dev Oct 28, 2025
@rubiin
Copy link

rubiin commented Oct 30, 2025

Excited for this.

@thibaultmol
Copy link
Contributor

thibaultmol commented Nov 3, 2025

(don't get me wrong, good feature, for most people, but not for me)
is there an about:config option to disable this button?

@mr-cheffy
Copy link
Member

mr-cheffy commented Nov 3, 2025

@thibaultmol

zen.view.show-clear-tabs-button next update

@BrixsterPlanet BrixsterPlanet mentioned this pull request Nov 18, 2025
Closed
5 tasks
@BrixsterPlanet
Copy link

BrixsterPlanet commented Nov 18, 2025

Because the button is attached to .pinned-tabs-container-separator, this feature does not work if there are no pinned tabs, as the separator will then be hidden.

Referenced in #11349

@Phosphorshy
Copy link

Phosphorshy commented Nov 21, 2025

Is it possible to have an (optional) confirmation prompt or have it listen to the "Ask before closing multiple tabs" setting, it feels a tad too easy to close all your tabs lol

(similar to how "Ask before closing multiple tabs" works for closing the browser when multiple tabs are open)
image

@12th-devs
Copy link
Contributor

12th-devs commented Nov 21, 2025

Is it possible to have an (optional) confirmation prompt or have it listen to the "Ask before closing multiple tabs" setting, it feels a tad too easy to close all your tabs lol

(similar to how "Ask before closing multiple tabs" works for closing the browser when multiple tabs are open)
image

I think that is why they allow you to undo it with a key bind, and promoting the users seems much less flowy (for a lack of a better word) then just a notification telling you how to undo your actions

1 similar comment
@12th-devs
Copy link
Contributor

12th-devs commented Nov 21, 2025

Is it possible to have an (optional) confirmation prompt or have it listen to the "Ask before closing multiple tabs" setting, it feels a tad too easy to close all your tabs lol

(similar to how "Ask before closing multiple tabs" works for closing the browser when multiple tabs are open)
image

I think that is why they allow you to undo it with a key bind, and promoting the users seems much less flowy (for a lack of a better word) then just a notification telling you how to undo your actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mr-cheffy mr-cheffy mr-cheffy approved these changes

Assignees

No one assigned

Labels

Feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@santhosh-chinnasamy @BrixsterPlanet @mr-cheffy @Eatham532 @rubiin @thibaultmol @Phosphorshy @12th-devs @reizumii