-
-
Notifications
You must be signed in to change notification settings - Fork 774
Initial implementation for folders and tree-styled tabs #7359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Why make it only work for pinned tabs, why not both? |
Because normal tabs should be disposable. I have another thing planned for normal tab grouping. This PR is just for folders |
For the nested folder and split view, I feel like it might be easier to match the parent margin like attached. This would ensure that the split view has enough room. I feel like at some point, there should be a max nested folder size or a way to configure the max size. Lastly, I am wondering if we should have a config option for the indent size? I know there is a number of people that set theirs to 0 to keep it kinda flat. |
I believe max should be 4 or 5, depending on how it turns out to be. First step is to actually get them... stacked. And for spacing, it should be logarithmic, where the more indents there are, the lower the spacing would be |
So should we ignore the title of this PR having “tree style tabs” in it? Will there be another PR opened for that? Or is this the single PR we can follow for tree style tabs as well? Thanks! |
Tree style tabs imply folders need to be stackable |
There are situations where I need to sort my normal tabs and keep them open for an extended period of time but don’t want to pin them. For instance, I’m making a modpack for Minecraft right now. When I’m researching mods, I open ones I’m considering in new tabs and sort them into groups by category (currently just using the somewhat working Firefox tab groups). These tabs are still disposable, since they’ll be closed eventually, but they’re still open long enough that they need good organization. If your plan for tab groups covers this, then cool. If it doesn’t, then I don’t see why users can’t have the choice to use folders for normal tabs if they want |
Is there a estimation for the release of this feature? I wanna suggest my team migrate to use Zen instead of Arc but this o course will be a discussion point 😂 |
Yeah, as I said, there's a third type of group planned for normal tabs. But I dont think they'll appear on the same release as folders. So it would end up being:
once zen reaches stable |
@mauro-balades makes sense and thanks for the clarifications! My only follow-up question is whether this third type of group for normal tabs will also support tree style tab primitives, meaning can have nested groups N levels deep (which I believe you refer to as "stackable")? Thanks!! |
Soon, I do want to give this feauter a nice week of purely testing as it's one of the things most people request.
That's still has to be decided on, im still unsure about normal tabs implementation. Im focusing on pinned tabs right now, sorry |
For drag and drop, we might just have to update to Firefox beta (138) since they already have this functionality... |
I don't think it should be so overcomplicated. You don't need three different things that are all folders. I agree you should focus on pinned tab folders right now, but please call it one name. |
Yeah, I'm just spitting out technicalities. Split views are just split views, but they are just groups at the end of the day |
so this is the spoiler for the new feature |
Functionality:
UI/UX: