feat: add Vietnamese translator #661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taroj1205
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Please run pnpm i -D @cspell/dict-vi-vn and install cspell plugin, and add it to cspell.json.
"language": "en,es,vi",Please also highlight a word in hero section for your translation where appropriate like English or Japanese.
Please also translate Workspaces etc in features section.
src/constants/i18n.ts
Outdated
Comment on lines
9
to
11
| { label: '日本語', value: 'ja', ui: UI_JA, intl: 'ja-JP' }, | ||
| {label:'Tiếng Việt', value: 'vi', ui: UI_EN, intl: 'vi-VN' }, | ||
| ], |
There was a problem hiding this comment.
Please change to use UI_VI
Suggested change
| { label: '日本語', value: 'ja', ui: UI_JA, intl: 'ja-JP' }, | |
| {label:'Tiếng Việt', value: 'vi', ui: UI_EN, intl: 'vi-VN' }, | |
| ], | |
| { label: '日本語', value: 'ja', ui: UI_JA, intl: 'ja-JP' }, | |
| {label:'Tiếng Việt', value: 'vi', ui: UI_VI, intl: 'vi-VN' }, | |
| ], |
src/components/Title.astro
Outdated
This reverts commit 2fc7026.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.