TAA-136: MVP of the Approval Request and Approval Request List page functionality #576
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| import { memo, useState, useMemo } from "react"; | ||
| import { useTranslation } from "react-i18next"; | ||
| import styled from "styled-components"; | ||
| import { MD, XXL } from "@zendeskgarden/react-typography"; | ||
| import { getColorV8 } from "@zendeskgarden/react-theming"; | ||
| import { Spinner } from "@zendeskgarden/react-loaders"; | ||
| import { useSearchApprovalRequests } from "./hooks/useSearchApprovalRequests"; | ||
| import ApprovalRequestListFilters from "./components/approval-request-list/ApprovalRequestListFilters"; | ||
| import ApprovalRequestListTable from "./components/approval-request-list/ApprovalRequestListTable"; | ||
|
|
||
| const Container = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: ${(props) => props.theme.space.lg}; | ||
| margin-top: ${(props) => props.theme.space.xl}; /* 40px */ | ||
| `; | ||
|
|
||
| const LoadingContainer = styled.div` | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| `; | ||
|
|
||
| const NoApprovalRequestsText = styled(MD)` | ||
| color: ${(props) => getColorV8("grey", 600, props.theme)}; | ||
| `; | ||
|
|
||
| export interface ApprovalRequestListPageProps { | ||
| baseLocale: string; | ||
| helpCenterPath: string; | ||
| } | ||
|
|
||
| type SortDirection = "asc" | "desc" | undefined; | ||
|
|
||
| function ApprovalRequestListPage({ | ||
| baseLocale, | ||
| helpCenterPath, | ||
| }: ApprovalRequestListPageProps) { | ||
| const { t } = useTranslation(); | ||
| const [searchTerm, setSearchTerm] = useState(""); | ||
| const [sortDirection, setSortDirection] = useState<SortDirection>(undefined); | ||
| const { | ||
| approvalRequests, | ||
| errorFetchingApprovalRequests: error, | ||
| approvalRequestStatus, | ||
| setApprovalRequestStatus, | ||
| isLoading, | ||
| } = useSearchApprovalRequests(); | ||
|
|
||
| const sortedAndFilteredApprovalRequests = useMemo(() => { | ||
|
There was a problem hiding this comment. Shouldn't filtering and sorting be handled via the api? There was a problem hiding this comment. Yes, ideally the filtering and sorting is both handled API side but that has not been implemented yet and we agreed to do this client side for the EAP. The results are currently unpaginated as well and we do have plans to sort/filter on the API long term |
||
| let results = [...approvalRequests]; | ||
|
|
||
| // Apply search filter | ||
| if (searchTerm) { | ||
| const term = searchTerm.toLowerCase(); | ||
| results = results.filter((request) => | ||
| request.subject.toLowerCase().includes(term) | ||
| ); | ||
| } | ||
|
|
||
| // Apply sorting | ||
| if (sortDirection) { | ||
| results.sort((a, b) => { | ||
| const dateA = new Date(a.created_at).getTime(); | ||
| const dateB = new Date(b.created_at).getTime(); | ||
| return sortDirection === "asc" ? dateA - dateB : dateB - dateA; | ||
| }); | ||
| } | ||
|
|
||
| return results; | ||
| }, [approvalRequests, searchTerm, sortDirection]); | ||
|
|
||
| if (error) { | ||
| throw error; | ||
|
There was a problem hiding this comment. nit: i know this is still MVP but we could note to handle errors gracefully in the future like a growl or something with better UX There was a problem hiding this comment. maybe similar to using notify below? There was a problem hiding this comment. Good callout, I followed the pattern used in the Service Catalog: https://github.com/zendesk/copenhagen_theme/blob/beta/src/modules/service-catalog/ServiceCatalogItemPage.tsx#L49-L51 This relies on the |
||
| } | ||
|
|
||
| if (isLoading) { | ||
| return ( | ||
| <LoadingContainer> | ||
| <Spinner size="64" /> | ||
| </LoadingContainer> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Container> | ||
| <XXL isBold> | ||
| {t("approval-requests.list.header", "Approval requests")} | ||
| </XXL> | ||
| <ApprovalRequestListFilters | ||
| approvalRequestStatus={approvalRequestStatus} | ||
| setApprovalRequestStatus={setApprovalRequestStatus} | ||
| setSearchTerm={setSearchTerm} | ||
| /> | ||
| {approvalRequests.length === 0 ? ( | ||
| <NoApprovalRequestsText> | ||
| {t( | ||
| "approval-requests.list.no-requests", | ||
| "No approval requests found." | ||
| )} | ||
| </NoApprovalRequestsText> | ||
| ) : ( | ||
| <ApprovalRequestListTable | ||
| approvalRequests={sortedAndFilteredApprovalRequests} | ||
| baseLocale={baseLocale} | ||
| helpCenterPath={helpCenterPath} | ||
| sortDirection={sortDirection} | ||
| onSortChange={setSortDirection} | ||
| /> | ||
| )} | ||
| </Container> | ||
| ); | ||
| } | ||
|
|
||
| export default memo(ApprovalRequestListPage); | ||
|
There was a problem hiding this comment. Just curious why do we need to memoize here? There was a problem hiding this comment. This is a habit/pre-optimization. In |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| import { memo } from "react"; | ||
| import styled from "styled-components"; | ||
| import { MD, XXL } from "@zendeskgarden/react-typography"; | ||
| import { Spinner } from "@zendeskgarden/react-loaders"; | ||
| import ApprovalRequestDetails from "./components/approval-request/ApprovalRequestDetails"; | ||
| import ApprovalTicketDetails from "./components/approval-request/ApprovalTicketDetails"; | ||
| import ApproverActions from "./components/approval-request/ApproverActions"; | ||
| import { useApprovalRequest } from "./hooks/useApprovalRequest"; | ||
| import type { Organization } from "../ticket-fields"; | ||
| import ApprovalRequestBreadcrumbs from "./components/approval-request/ApprovalRequestBreadcrumbs"; | ||
|
|
||
| const Container = styled.div` | ||
| display: flex; | ||
| flex-direction: row; | ||
| margin-top: ${(props) => props.theme.space.xl}; /* 40px */ | ||
| margin-bottom: ${(props) => props.theme.space.lg}; /* 32px */ | ||
|
|
||
| @media (max-width: ${(props) => props.theme.breakpoints.md}) { | ||
| flex-direction: column; | ||
| margin-bottom: ${(props) => props.theme.space.xl}; /* 40px */ | ||
| } | ||
| `; | ||
|
|
||
| const LoadingContainer = styled.div` | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| `; | ||
|
|
||
| const LeftColumn = styled.div` | ||
| flex: 2; | ||
|
|
||
| & > *:first-child { | ||
| margin-bottom: ${(props) => props.theme.space.base * 4}px; /* 16px */ | ||
| } | ||
|
|
||
| & > *:not(:first-child) { | ||
| margin-bottom: ${(props) => props.theme.space.lg}; /* 32px */ | ||
| } | ||
|
|
||
| & > *:last-child { | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| @media (max-width: ${(props) => props.theme.breakpoints.md}) { | ||
| flex: 1; | ||
| margin-right: 0; | ||
| margin-bottom: ${(props) => props.theme.space.lg}; | ||
| } | ||
| `; | ||
|
|
||
| const RightColumn = styled.div` | ||
| flex: 1; | ||
| margin-left: ${(props) => props.theme.space.base * 6}px; /* 24px */ | ||
|
|
||
| @media (max-width: ${(props) => props.theme.breakpoints.md}) { | ||
| margin-left: 0; | ||
| } | ||
| `; | ||
|
|
||
| export interface ApprovalRequestPageProps { | ||
| approvalWorkflowInstanceId: string; | ||
| approvalRequestId: string; | ||
| baseLocale: string; | ||
| helpCenterPath: string; | ||
| organizations: Array<Organization>; | ||
| userId: number; | ||
| } | ||
|
|
||
| function ApprovalRequestPage({ | ||
| approvalWorkflowInstanceId, | ||
| approvalRequestId, | ||
| baseLocale, | ||
| helpCenterPath, | ||
| organizations, | ||
| userId, | ||
| }: ApprovalRequestPageProps) { | ||
| const { | ||
| approvalRequest, | ||
| setApprovalRequest, | ||
| errorFetchingApprovalRequest: error, | ||
| isLoading, | ||
| } = useApprovalRequest(approvalWorkflowInstanceId, approvalRequestId); | ||
|
|
||
| if (error) { | ||
| throw error; | ||
| } | ||
|
|
||
| if (isLoading) { | ||
| return ( | ||
| <LoadingContainer> | ||
| <Spinner size="64" /> | ||
| </LoadingContainer> | ||
| ); | ||
| } | ||
|
|
||
| const showApproverActions = | ||
| userId === approvalRequest?.assignee_user?.id && | ||
| approvalRequest?.status === "active"; | ||
|
|
||
| return ( | ||
| <> | ||
| <ApprovalRequestBreadcrumbs | ||
| helpCenterPath={helpCenterPath} | ||
| organizations={organizations} | ||
| /> | ||
| <Container> | ||
| <LeftColumn> | ||
| <XXL isBold>{approvalRequest?.subject}</XXL> | ||
| <MD>{approvalRequest?.message}</MD> | ||
| {approvalRequest?.ticket_details && ( | ||
| <ApprovalTicketDetails ticket={approvalRequest.ticket_details} /> | ||
| )} | ||
| </LeftColumn> | ||
| <RightColumn> | ||
| {approvalRequest && ( | ||
| <ApprovalRequestDetails | ||
| approvalRequest={approvalRequest} | ||
| baseLocale={baseLocale} | ||
| /> | ||
| )} | ||
| </RightColumn> | ||
| </Container> | ||
| {showApproverActions && ( | ||
| <ApproverActions | ||
| approvalWorkflowInstanceId={approvalWorkflowInstanceId} | ||
| approvalRequestId={approvalRequestId} | ||
| setApprovalRequest={setApprovalRequest} | ||
| assigneeUser={approvalRequest?.assignee_user} | ||
| /> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default memo(ApprovalRequestPage); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luis-almeida I ended up adding a
__tests__directory within the approval-requests module and this was throwing an eslint error on those files. Let me know if you want to handle this differently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be ok to colocate the tests? e.g.: https://github.com/zendesk/copenhagen_theme/blob/master/src/modules/new-request-form/getVisibleFields.test.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to colocate the tests in 7d1ddab which removed the need for the eslint updates