Fix versioned db tests #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cases `TestVersionedDBConcurrentUse` and `TestVersionedDBVersions` in `versioned_db_test.go` will fail because the `LevelDBManager` instances are not cleaned up during teardown. The following error messages will be shown when running the tests: ```TempDir RemoveAll cleanup: remove ...\TestVersionedDBConcurrentUse2208946391\001\000001.log: The process cannot access the file because it is being used by another process.``` ```TempDir RemoveAll cleanup: remove ...\TestVersionedDBVersions80412342\001\000002.ldb: The process cannot access the file because it is being used by another process.``` This commit makes sure the resources are properly cleaned up during teardown.
Collaborator
|
Ideally, I would want someone to recreate this issue. @vilkris4 mentioned this was on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases
TestVersionedDBConcurrentUseandTestVersionedDBVersionsinversioned_db_test.gowill fail because theLevelDBManagerinstances are not cleaned up during teardown.The following error messages will be shown when running the tests:
TempDir RemoveAll cleanup: remove ...\TestVersionedDBConcurrentUse2208946391\001\000001.log: The process cannot access the file because it is being used by another process.TempDir RemoveAll cleanup: remove ...\TestVersionedDBVersions80412342\001\000002.ldb: The process cannot access the file because it is being used by another process.This commit makes sure the resources are properly cleaned up during teardown.