Allow selectFieldOptions to deselect all values #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition @notFloran! I made some tweaks to get the Panther tests passing and merged your commit in #143 (I didn't have permission to update your fork's branch). |
Oh thanks ! I was unable to correct the Panther part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a select multiple and in one of my test I need to unselect all values, I try
->selectFieldOption('Réparateur(s)', [])without result.The method
selectFieldOptionsuse a foreach and theselectFieldOptionof Mink and so do nothing when I pass an empty array.After some digging, I found that Mink use the following syntax to do that :
->page()->fillField($selector, []);(see minkphp/Mink#374 (comment)).