Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schedule objects for insert right after instantiation #742

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Dec 11, 2024

⚠️ merge #738 before

fixes #537
fixes #724

@nikophil nikophil requested a review from kbond December 11, 2024 18:23
@nikophil nikophil changed the title feat/persist after instantiate feat: schedule objects for insert right after instantiation Dec 11, 2024
@simondaigre
Copy link
Contributor

Minor comment : before this PR, when I use UserFactory::find(['customer' => $customer]); on Factory and when there is no results, the error was RuntimeException: Could not find "App\Entity\User" object.

And now it's RuntimeException: No "App\Entity\User" object found for "array"., which is unclear.

@nikophil
Copy link
Member Author

@simondaigre is it related to this PR or Foundry 2? 🤔

if not related to this PR, but to foundry 2, could you please open another issue?

@nikophil nikophil force-pushed the feat/persist-after-instantiate branch from d54febe to ec34c33 Compare December 12, 2024 15:08
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@nikophil nikophil merged commit 98f018c into zenstruck:2.x Dec 14, 2024
54 checks passed
@nikophil nikophil deleted the feat/persist-after-instantiate branch December 14, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants