Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(faker): Improve reproducibility with faker #807

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat(faker): Improve reproducibility with faker #807

merged 3 commits into from
Feb 24, 2025
+300 −5

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Feb 5, 2025 •
edited
Loading

fixes #793

This PR does the following:

  • deprecate faker.seed config
  • load faker seed from the en var FOUNDRY_FAKER_SEED
  • always set a random seed if not provided by the env var (and the legacy config)
  • display the seed after PHPUnit has run

@nikophil nikophil changed the title feat/faker seed feat(faker): Improve reproducibility with faker Feb 5, 2025
@nikophil nikophil force-pushed the feat/faker-seed branch 3 times, most recently from 7063430 to fb1ad2e Compare February 9, 2025 13:42
@nikophil nikophil requested a review from kbond February 9, 2025 13:47
kbond
kbond approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nikophil nikophil merged commit eb6e983 into zenstruck:2.x Feb 24, 2025
67 checks passed
@nikophil nikophil deleted the feat/faker-seed branch February 24, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve reproducibility with faker
2 participants
@nikophil @kbond