Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent infinite loop when ->create() is called in after persist callback #832

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: prevent infinite loop when ->create() is called in after persist callback #832

merged 1 commit into from
Feb 25, 2025

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Feb 25, 2025 •
edited
Loading

fixes #830

@nikophil nikophil mentioned this pull request Feb 25, 2025
Closed
@nikophil nikophil force-pushed the fix/infinite-loop-after-persist branch from 9f0e258 to 7d35a28 Compare February 25, 2025 17:33
@nikophil nikophil changed the title fix: can call ->create() in after persist callback fix: prevent infinite loop when ->create() is called in after persist callback Feb 25, 2025
@nikophil nikophil merged commit 5647b5c into zenstruck:2.x Feb 25, 2025
67 checks passed
@nikophil nikophil deleted the fix/infinite-loop-after-persist branch February 25, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using afterPersist for the OwningSide with an inversed one to one relationship leads to infinite loop
1 participant
@nikophil