fix: handle "inverse one to one" without "placeholder" solution #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
force-pushed
the
fix/remove-placeholder
branch
from
ba5bbca to
2173a48
Compare
nikophil
force-pushed
the
fix/remove-placeholder
branch
from
2173a48 to
b9a7c6b
Compare
nikophil
commented
Mar 30, 2025
kbond
approved these changes
Mar 30, 2025
tests/Integration/ORM/EntityRelationship/EntityFactoryRelationshipTestCase.php
Show resolved
Hide resolved
nikophil
added a commit
to nikophil/foundry
that referenced
this pull request
Mar 31, 2025
* 2.3.x: bot: fix cs [skip ci] fix: handle "inverse one to one" without "placeholder" solution (zenstruck#855) bot: fix cs [skip ci] feat: add force() helper (zenstruck#854) chore: add support for doctrine/persistence 4 (zenstruck#852) fix: fix doctrine collection with union/intersection type (zenstruck#847) bot: fix cs [skip ci] fix: bug with factory collectin of persistent factory in unit test (zenstruck#842) fix: use Doctrine metadata event when persist is disabled (zenstruck#841) minor: add parameter "withAutoRefresh" to unproxy() function (zenstruck#840) chore: upgrade also dama when upgrading phpunit version (zenstruck#839) bot: fix cs [skip ci] changelog: update [skip ci] fix: can call ->create() in after persist callback (zenstruck#833)
Merged
nikophil
added a commit
that referenced
this pull request
Mar 31, 2025
* fix: can call ->create() in after persist callback (#833) * changelog: update [skip ci] * bot: fix cs [skip ci] * chore: upgrade also dama when upgrading phpunit version (#839) * minor: add parameter "withAutoRefresh" to unproxy() function (#840) * fix: use Doctrine metadata event when persist is disabled (#841) * fix: bug with factory collectin of persistent factory in unit test (#842) * bot: fix cs [skip ci] * fix: fix doctrine collection with union/intersection type (#847) * fix: fix hydrator with doctrine collections using intersection types * feat: add unit tests for hydrator * test: add functional test for union type --------- Co-authored-by: Nicolas PHILIPPE <[email protected]> * chore: add support for doctrine/persistence 4 (#852) * feat: add force() helper (#854) * bot: fix cs [skip ci] * fix: handle "inverse one to one" without "placeholder" solution (#855) * fix: one to one no more uses placeholder * fix: use different error message if types are missing * bot: fix cs [skip ci] * changelog: update --------- Co-authored-by: nikophil <[email protected]> Co-authored-by: Maarten de Boer <[email protected]> Co-authored-by: chris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will hopefully fix every problem with "inverse one to one", in a simpler way than the "placeholder" solution which introduced a lot of glitches.
now, the inverse one to one is resolved this way:
fixes #835