Skip to content

nrfx: samples: nrfx_saadc: align to nrfx 3.12 API change #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nika-nordic
Copy link
Contributor

@nika-nordic nika-nordic commented Jun 23, 2025

NRFX_SAADC_SAMPLE_GET() macro takes two arguments now instead of three.

@anangl
Copy link
Member

anangl commented Jun 23, 2025

Since SAADC samples are updated, perhaps it would be good to also remove this stuff:

#if (NRF_SAADC_8BIT_SAMPLE_WIDTH == 8) && (RESOLUTION == NRF_SAADC_RESOLUTION_8BIT)
static uint8_t m_samples_buffer[BUFFER_SIZE];
from those samples?

NRFX_SAADC_SAMPLE_GET() macro takes two arguments now
instead of three.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic force-pushed the fix_saadc_nrfx_samples_halnordic branch from d9fcfc1 to d9ae7fa Compare June 23, 2025 10:25
@nika-nordic
Copy link
Contributor Author

Since SAADC samples are updated, perhaps it would be good to also remove this stuff:

#if (NRF_SAADC_8BIT_SAMPLE_WIDTH == 8) && (RESOLUTION == NRF_SAADC_RESOLUTION_8BIT)
static uint8_t m_samples_buffer[BUFFER_SIZE];

from those samples?

let's do that on occasion of next nrfx release

@nika-nordic
Copy link
Contributor Author

to be replaced by #308

@nika-nordic
Copy link
Contributor Author

replaced by #308 - to be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants