Skip to content

Conversation

duynguyenxa
Copy link
Member

This is the commit to support for drw driver on Renesas RA devices
The commit includes FSP driver for DRW and blob information for the libdave2d

This is the commit to support for drw driver on Renesas RA

Signed-off-by: Duy Nguyen <[email protected]>
@KhiemNguyenT
Copy link
Collaborator

@nhutnguyenkc @binhnguyen2434 please take a look.

Copy link
Contributor

@thenguyenyf thenguyenyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other files are identical with FSP v6.1.0 and look good to me.

Comment on lines +1 to +5
/*
* Copyright (c) 2020 - 2024 Renesas Electronics Corporation and/or its affiliates
*
* SPDX-License-Identifier: BSD-3-Clause
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is difference from FSP v6.1.0

Comment on lines +1 to +5
/*
* Copyright (c) 2020 - 2024 Renesas Electronics Corporation and/or its affiliates
*
* SPDX-License-Identifier: BSD-3-Clause
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is difference from FSP v6.1.0

Comment on lines +103 to +107
zephyr_link_libraries(${CMAKE_CURRENT_SOURCE_DIR}/../../zephyr/blobs/dave2d/libdave2d.a)
zephyr_library_sources(
fsp/src/r_drw/r_drw_base.c
fsp/src/r_drw/r_drw_memory.c)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code formatting/line indentation should be update follow this file

ra_cfg/fsp_cfg
fsp/src/bsp/mcu/all
fsp/src/bsp/cmsis/Device/RENESAS/Include
fsp/src/r_drw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move it to bellow line 102 (wrapped by CONFIG_USE_RA_FSP_DRW)?

* 2008-04-30 MRe added RLE and subbyte formats
* 2008-06-12 MRe added CLUT256 and color keying
* 2008-07-14 ASt added additional performance counter values
* 2009-01-16 MRe added defines for feature bits from dave_registermap.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines are different from FSP v6.1.0, but for me that is not an issue that needs to be fixed (it looks like a formatting issue of FSP source code)
image

@@ -0,0 +1,14 @@
/* generated configuration header file - do not edit */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be updated

Comment on lines +4 to +13
#ifdef __cplusplus
extern "C" {
#endif

#define DRW_CFG_USE_DLIST_INDIRECT ((1))
#define DRW_CFG_CUSTOM_MALLOC ((1))

#ifdef __cplusplus
}
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may need to be re-formatted

Comment on lines +35 to +48
#if CONFIG_LV_USE_DRAW_DAVE2D
#define LV_ZEPHYR_INPUT_PIXEL_FORMAT \
DT_PROP(DT_CHOSEN(zephyr_display), input_pixel_format)

#if (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_RGB_565)
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_16BITS_RGB565
#elif (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_RGB_888)
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_32BITS_RGB888
#elif (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_ARGB_8888)
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_32BITS_ARGB8888
#else /* Unsupported format */
#define LV_DISPLAY_INPUT_FORMAT (-1)
#endif
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may need to be re-formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants