-
Notifications
You must be signed in to change notification settings - Fork 18
hal: ra: Initial update for drw driver #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hal: ra: Initial update for drw driver #154
Conversation
This is the commit to support for drw driver on Renesas RA Signed-off-by: Duy Nguyen <[email protected]>
@nhutnguyenkc @binhnguyen2434 please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other files are identical with FSP v6.1.0 and look good to me.
/* | ||
* Copyright (c) 2020 - 2024 Renesas Electronics Corporation and/or its affiliates | ||
* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is difference from FSP v6.1.0
/* | ||
* Copyright (c) 2020 - 2024 Renesas Electronics Corporation and/or its affiliates | ||
* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is difference from FSP v6.1.0
zephyr_link_libraries(${CMAKE_CURRENT_SOURCE_DIR}/../../zephyr/blobs/dave2d/libdave2d.a) | ||
zephyr_library_sources( | ||
fsp/src/r_drw/r_drw_base.c | ||
fsp/src/r_drw/r_drw_memory.c) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code formatting/line indentation should be update follow this file
ra_cfg/fsp_cfg | ||
fsp/src/bsp/mcu/all | ||
fsp/src/bsp/cmsis/Device/RENESAS/Include | ||
fsp/src/r_drw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move it to bellow line 102 (wrapped by CONFIG_USE_RA_FSP_DRW
)?
* 2008-04-30 MRe added RLE and subbyte formats | ||
* 2008-06-12 MRe added CLUT256 and color keying | ||
* 2008-07-14 ASt added additional performance counter values | ||
* 2009-01-16 MRe added defines for feature bits from dave_registermap.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,14 @@ | |||
/* generated configuration header file - do not edit */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright should be updated
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
#define DRW_CFG_USE_DLIST_INDIRECT ((1)) | ||
#define DRW_CFG_CUSTOM_MALLOC ((1)) | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may need to be re-formatted
#if CONFIG_LV_USE_DRAW_DAVE2D | ||
#define LV_ZEPHYR_INPUT_PIXEL_FORMAT \ | ||
DT_PROP(DT_CHOSEN(zephyr_display), input_pixel_format) | ||
|
||
#if (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_RGB_565) | ||
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_16BITS_RGB565 | ||
#elif (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_RGB_888) | ||
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_32BITS_RGB888 | ||
#elif (LV_ZEPHYR_INPUT_PIXEL_FORMAT == PANEL_PIXEL_FORMAT_ARGB_8888) | ||
#define LV_DISPLAY_INPUT_FORMAT DISPLAY_IN_FORMAT_32BITS_ARGB8888 | ||
#else /* Unsupported format */ | ||
#define LV_DISPLAY_INPUT_FORMAT (-1) | ||
#endif | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may need to be re-formatted
This is the commit to support for drw driver on Renesas RA devices
The commit includes FSP driver for DRW and blob information for the libdave2d