scripts: genpinctrl: add eth pins for stm32h7rs #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
previously requested changes
Jul 22, 2025
Update pinctrl-config to generate ETH_MII & ETH_RMII. STM32H7RS uses a different declaration format for the eth pinctrl Signed-off-by: Mario Paja <[email protected]>
mariopaja
force-pushed
the
gen_script_h7rs_eth
branch
from
6c2eef9 to
ef6adb7
Compare
|
@mariopaja Just to be sure, is the last commit is the full output of ? I mean the effect of your changes to the whole STM32 family ? Tbh I'd be surprised. |
mariopaja
force-pushed
the
gen_script_h7rs_eth
branch
3 times, most recently
from
506ea02 to
42c5005
Compare
|
@erwango I noticed that the issue was the JTAG PORT |
erwango
reviewed
Jul 23, 2025
| /omit-if-no-ref/ debug_njtrst_pb4: debug_njtrst_pb4 { | ||
| /omit-if-no-ref/ debug_jtrst_pb4: debug_jtrst_pb4 { |
There was a problem hiding this comment.
@asm5878, @benothmn-st Is there a plan to fix this oddity ?
|
@mariopaja Can you drop the WBA JTAG PORT changes? This is an issue on our side that should be fixed. Otherwise LGTM |
Add stm32h7rs pinctrl ETH_MII & ETH_RMII Signed-off-by: Mario Paja <[email protected]>
mariopaja
force-pushed
the
gen_script_h7rs_eth
branch
from
42c5005 to
d5b911f
Compare
erwango
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pinctrl-config to generate ETH_MII & ETH_RMII.
STM32H7RS uses a different declaration format for the eth pinctrl compared to H7 or N6 series