Riscv fixes #940
Merged
Riscv fixes #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
approved these changes
Jun 9, 2025
| @@ -23,6 +23,9 @@ config PICOLIBC_DEFAULT | |||
| help | |||
| Zephyr SDK >=0.17.1 always uses Picolibc | |||
|
|
|||
| # libstdc++ is built without exception support in -Os mode | |||
| # gcc 14.3 has bugs compiling with -Os on riscv | |||
There was a problem hiding this comment.
Is there an upstream GCC PR for this?
There was a problem hiding this comment.
There is an upstream PR for the multilib changes, but they've been queued for long time now. I have no idea if they'll ever be approved.
There was a problem hiding this comment.
I don't have a patch for the -Os issues with risc-v (yet?)
|
@keith-packard This needs to be rebased. |
gcc 14.3 has bus compiling with -Os on riscv, use -O2 by default. Is there some way to prevent applications from selecting -Os? Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
riscv-fixes
branch
from
81c6423 to
38b0291
Compare
The -mstrict-align patch for gcc was already applied, so I just rebased the optimization flag change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SPEED_OPTIMIZATIONS by default for riscv (avoids compiler bugs with -Os).
Use -mstrict-align by default (avoids emitting misaligned memory operations).