driver: flash: initial support for Renesas RZ/A3UL, T2M, N2L #96781

tiennguyenzg · 2025-09-30T10:08:23Z

This driver is based on the XSPI_QSPI driver for Renesas RZ/T2M and N2L, and the SPIBSC driver for Renesas RZ/A3UL from the HAL.

Need: zephyrproject-rtos/hal_renesas#149 (merged)

github-actions · 2025-09-30T10:09:28Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`5ab2c84`	zephyrproject-rtos/hal_renesas@`3ce2bdc`	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

quytranpzz · 2025-10-10T03:14:57Z

boards/renesas/rza3ul_smarc/rza3ul_smarc.dts

+
+			slot0_partition: partition@20200 {
+				label = "image-0";
+				reg = <0x00020200 (DT_SIZE_M(16) - 0x20200)>;


should we use reg = <0x00020200 0xFDFE00>; instead?

I would like to retain this value because it is more readable and easier to maintain.

quytranpzz · 2025-10-10T03:25:31Z

drivers/flash/flash_renesas_rz_qspi.c

+					     .command_length = 1U,
+					     .address_length = 0U,
+					     .data_length = THREE_BYTE,
+					     .dummy_cycles = 0U};


just for formatting

Suggested change

.dummy_cycles = 0U};

.dummy_cycles = 0U,};

quytranpzz · 2025-10-10T03:40:46Z

drivers/flash/flash_renesas_rz_qspi.c

+					     .command_length = 1U,
+					     .address_length = 3U,
+					     .data_length = FOUR_BYTE,
+					     .dummy_cycles = SPI_NOR_DUMMY_RD};


Suggested change

.dummy_cycles = SPI_NOR_DUMMY_RD};

.dummy_cycles = SPI_NOR_DUMMY_RD,};

quytranpzz · 2025-10-10T03:42:15Z

drivers/flash/flash_renesas_rz_qspi.c

+
+static int qspi_flash_rz_read(const struct device *dev, off_t offset, void *data, size_t len)
+{
+


Suggested change

quytranpzz · 2025-10-10T03:44:43Z

drivers/flash/flash_renesas_rz_qspi.c

+					     .command_length = 1U,
+					     .address_length = 0U,
+					     .data_length = data_length,
+					     .dummy_cycles = 0U};


Suggested change

.dummy_cycles = 0U};

.dummy_cycles = 0U,};

quytranpzz · 2025-10-10T06:37:41Z

drivers/flash/flash_renesas_rz_qspi.c

+	struct flash_renesas_rz_data *data = dev->data;
+	spi_flash_status_t status = {.write_in_progress = true};
+	uint32_t timeout = UINT32_MAX;
+	fsp_err_t err = 0;


drop the initialized value since you literally set this in config->fsp_api->statusGet and you're using return 0

I have updated it. Thank you.

quytranpzz · 2025-10-10T06:38:24Z

drivers/flash/flash_renesas_rz_qspi.c

+
+	while ((status.write_in_progress) && (timeout > 0)) {
+		err = config->fsp_api->statusGet(data->fsp_ctrl, &status);
+		if (FSP_SUCCESS != (fsp_err_t)err) {


No need to cast it again since it's already declared as fsp_err_t

I have updated it. Thank you.

quytranpzz · 2025-10-10T06:42:04Z

drivers/flash/Kconfig.renesas_rz_qspi

+# SPDX-License-Identifier: Apache-2.0
+
+config FLASH_RENESAS_RZ_QSPI_XSPI
+	bool "Renesas RZ Quad-SPI driver"


Suggested change

bool "Renesas RZ Quad-SPI driver"

bool "Renesas RZ Quad-SPI XPSI driver"

quytranpzz · 2025-10-10T06:42:28Z

drivers/flash/Kconfig.renesas_rz_qspi

+	  Enable Quad-SPI XSPI Nor flash driver for RZ series
+
+config FLASH_RENESAS_RZ_QSPI_SPIBSC
+	bool "Renesas RZ Quad-SPI driver"


Suggested change

bool "Renesas RZ Quad-SPI driver"

bool "Renesas RZ Quad-SPI SPIBC driver"

quytranpzz · 2025-10-10T06:48:06Z

drivers/flash/flash_renesas_rz_qspi.c

+#define QSPI_DEFAULT_SR     (0x40)
+#define QSPI_UPDATE_CR      (0xC0) /* Configuration register (DC0=1, DC1=1 (Dummy cycle = 10)) */
+#define QSPI_DATA_CR_UPDATE (QSPI_UPDATE_CR << 8 | QSPI_DEFAULT_SR)


Suggested change

#define QSPI_DEFAULT_SR (0x40)

#define QSPI_UPDATE_CR (0xC0) /* Configuration register (DC0=1, DC1=1 (Dummy cycle = 10)) */

#define QSPI_DATA_CR_UPDATE (QSPI_UPDATE_CR << 8 | QSPI_DEFAULT_SR)

#ifdef CONFIG_FLASH_RENESAS_RZ_QSPI_XSPI

#define QSPI_DEFAULT_SR (0x40)

#define QSPI_UPDATE_CR (0xC0) /* Configuration register (DC0=1, DC1=1 (Dummy cycle = 10)) */

#define QSPI_DATA_CR_UPDATE (QSPI_UPDATE_CR << 8 | QSPI_DEFAULT_SR)

#endif /* CONFIG_FLASH_RENESAS_RZ_QSPI_XSPI */

tiennguyenzg · 2025-10-14T07:45:19Z

First push: Rebase to resolve conflict
Second push: Update for feedback

de-nordic

Sample and tests look ok.

Update commit id for hal_renesas to support Flash driver for Renesas RZ/A, T, N series Signed-off-by: Tien Nguyen <[email protected]>

This driver is based on the XSPI driver for Renesas RZ/T2M and N2L, and the SPIBSC driver for Renesas RZ/A3UL from the HAL. Signed-off-by: Tien Nguyen <[email protected]>

Add SPIBSC node for RZ/A3UL Add XSPI node for RZ/T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

Add flash memory regions for RZ/A3UL Signed-off-by: Tien Nguyen <[email protected]>

Add flash support for RZ/A3UL, N2L, T2M Signed-off-by: Tien Nguyen <[email protected]>

Add Flash driver for RZ/A3UL, T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

Add a macro to define the 32KB block size in spi_nor.h Signed-off-by: Tien Nguyen <[email protected]>

sonarqubecloud · 2025-10-22T02:56:42Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.6% Duplication on New Code

See analysis details on SonarQube Cloud

tiennguyenzg · 2025-10-22T03:19:32Z

Hi @de-nordic, @binhnguyen2434, @quytranpzz
I just rebased to pick up commits of #97971 to fix CI failures.
Could you help me take another look? Thank you.

github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 30, 2025

zephyrbot requested review from KhiemNguyenT, andrzej-kaczmarek, binhnguyen2434, blauret, de-nordic, decsny, ioannis-karachalios, lorc, nashif, nhutnguyenkc, rghaddab, tbursztyka, teburd, tgorochowik and xakep-amatop September 30, 2025 10:10

zephyrbot assigned de-nordic Sep 30, 2025

tiennguyenzg added this to the v4.3.0 milestone Sep 30, 2025

tiennguyenzg added the platforms: Renesas RZ label Sep 30, 2025

decsny removed their request for review September 30, 2025 16:35

tiennguyenzg force-pushed the rz_support_flash branch from 1be274e to bd0d144 Compare October 1, 2025 04:32

zephyrbot requested a review from ydamigos October 1, 2025 04:34

quytranpzz reviewed Oct 10, 2025

View reviewed changes

binhnguyen2434 self-assigned this Oct 13, 2025

tiennguyenzg force-pushed the rz_support_flash branch from bd0d144 to 23fd2b5 Compare October 13, 2025 10:11

zephyrbot requested a review from kartben October 13, 2025 10:12

tiennguyenzg force-pushed the rz_support_flash branch from 23fd2b5 to ea84bba Compare October 14, 2025 07:42

tiennguyenzg force-pushed the rz_support_flash branch 2 times, most recently from 2a86aaf to 585455b Compare October 17, 2025 08:31

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 17, 2025

de-nordic previously approved these changes Oct 17, 2025

View reviewed changes

de-nordic removed their assignment Oct 17, 2025

binhnguyen2434 previously approved these changes Oct 18, 2025

View reviewed changes

tiennguyenzg dismissed stale reviews from binhnguyen2434 and de-nordic via 027501e October 21, 2025 02:39

tiennguyenzg force-pushed the rz_support_flash branch from 585455b to 027501e Compare October 21, 2025 02:39

zephyrbot requested review from binhnguyen2434 and de-nordic October 21, 2025 02:41

tiennguyenzg added 9 commits October 22, 2025 09:26

hal: renesas: manifest: Update commit id for hal_renesas

350b5a4

Update commit id for hal_renesas to support Flash driver for Renesas RZ/A, T, N series Signed-off-by: Tien Nguyen <[email protected]>

driver: flash: initial support for Renesas RZ/A3UL, T2M, N2L

09127da

This driver is based on the XSPI driver for Renesas RZ/T2M and N2L, and the SPIBSC driver for Renesas RZ/A3UL from the HAL. Signed-off-by: Tien Nguyen <[email protected]>

dts: renesas: Add flash support for RZ/A3UL, N2L, T2M

14bb0df

Add SPIBSC node for RZ/A3UL Add XSPI node for RZ/T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

soc: renesas: Add flash memory regions for RZ/A3UL

d4340e0

Add flash memory regions for RZ/A3UL Signed-off-by: Tien Nguyen <[email protected]>

boards: renesas: Add flash support for RZ/A3UL, N2L, T2M

74692bc

Add flash support for RZ/A3UL, N2L, T2M Signed-off-by: Tien Nguyen <[email protected]>

tests: driver: flash: Add Flash driver for RZ/A3UL, T2M, N2L

87b8ad1

Add Flash driver for RZ/A3UL, T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

samples: driver: jesd216: Add Flash driver for RZ/A3UL, T2M, N2L

9b4eb68

Add Flash driver for RZ/A3UL, T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

samples: drivers: spi_flash: Add Flash driver for RZ/A3UL, T2M, N2L

42ef128

Add Flash driver for RZ/A3UL, T2M, N2L Signed-off-by: Tien Nguyen <[email protected]>

driver: flash: Add a macro to define the 32KB block size in spi_nor.h

c2adcb0

Add a macro to define the 32KB block size in spi_nor.h Signed-off-by: Tien Nguyen <[email protected]>

tiennguyenzg force-pushed the rz_support_flash branch from 027501e to c2adcb0 Compare October 22, 2025 02:28

binhnguyen2434 approved these changes Oct 22, 2025

View reviewed changes

KhiemNguyenT approved these changes Oct 22, 2025

View reviewed changes

kartben merged commit 5341c88 into zephyrproject-rtos:main Oct 22, 2025
30 checks passed

	.dummy_cycles = SPI_NOR_DUMMY_RD};
	.dummy_cycles = SPI_NOR_DUMMY_RD,};


		static int qspi_flash_rz_read(const struct device dev, off_t offset, void data, size_t len)
		{

	bool "Renesas RZ Quad-SPI driver"
	bool "Renesas RZ Quad-SPI XPSI driver"

	bool "Renesas RZ Quad-SPI driver"
	bool "Renesas RZ Quad-SPI SPIBC driver"

driver: flash: initial support for Renesas RZ/A3UL, T2M, N2L #96781

driver: flash: initial support for Renesas RZ/A3UL, T2M, N2L #96781

Conversation

tiennguyenzg commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiennguyenzg Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiennguyenzg commented Oct 14, 2025

Uh oh!

de-nordic left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Quality Gate passed

Uh oh!

tiennguyenzg commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tiennguyenzg commented Sep 30, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading

tiennguyenzg Oct 14, 2025 •

edited

Loading