Refactor init and add compression support. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knadh
force-pushed
the
v2
branch
2 times, most recently
from
9610b3d to
3595bd6
Compare
- Break to `/v2` to introduce `Options{}` that's pass to lib init.
- Add `CompressOptions{}` to enable zstd|br|gzip|deflate auto-compression
support offered by fasthttp.
rhnvrm
reviewed
Feb 5, 2025
|
|
||
| // If compression is enabled, wrap the handler with fasthttp's CompressHandler | ||
| // which automatically handles the compression logic. | ||
| if f.opt.CompressionOpt.Enabled { |
There was a problem hiding this comment.
Maybe we can rename this to opt.Compression? Type name can remain CompressionOpt.
| // Fastglue is the "glue" wrapper over fasthttp and fasthttprouter. | ||
| type Fastglue struct { | ||
| Router *fasthttprouter.Router | ||
| Server *fasthttp.Server | ||
| context interface{} | ||
| MatchedRoutePathParam string |
There was a problem hiding this comment.
MatchedRoutePathParam
This is setup in NewGlue in custom.go, maybe it can be an opt since currently we depend on NewGlue()
fastglue.NewGlue() <- Deprecate this since we are doing a v2?
| @@ -77,7 +77,7 @@ func myRedirectHandler(r *fastglue.Request) error { | |||
| } | |||
|
|
|||
| func main() { | |||
| f := fastglue.NewGlue() | |||
| f := fastglue.NewGlue(fastglue.Options{}) | |||
There was a problem hiding this comment.
New vs New Glue, its confusing can be deprecated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v2to introduceOptions{}that's pass to lib init.CompressOptions{}to enable zstd|br|gzip|deflate auto-compression support offered by fasthttp.