Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes driven by zguide examples work #21

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

gar1t
Copy link

@gar1t gar1t commented Aug 7, 2011

With the exception of some trivial docs-related changes, these were driven by zguide Erlang example rework here:

booksbyus/zguide#92

@yrashk
Copy link
Member

yrashk commented Oct 20, 2011

I apologize, I totally forgot about this pull request. Hopefully will have a chance to go through it soon!

@gar1t
Copy link
Author

gar1t commented Oct 20, 2011

Hah, no worries. I figure we could sync up in Stockholm.

On Thu, Oct 20, 2011 at 9:31 AM, Yurii Rashkovskii
[email protected]
wrote:

I apologize, I totally forgot about this pull request. Hopefully will have a chance to go through it soon!

Reply to this email directly or view it on GitHub:
#21 (comment)

@yrashk
Copy link
Member

yrashk commented Nov 28, 2011

Hey, I want to merge this in, however I am not sure I am ready to include cdf4408 and especially c0587bb. Would you mind if I merge without them?

@yrashk
Copy link
Member

yrashk commented Nov 28, 2011

Or at least I'd suggest handling them separately.

@gar1t
Copy link
Author

gar1t commented Nov 28, 2011

Yah, go ahead with the others.

@benoitc
Copy link

benoitc commented Apr 13, 2012

what happend to that ?

@yrashk
Copy link
Member

yrashk commented Apr 13, 2012

I think I forgot about this. Right now there are way too many merges to merge this in.

@gar1t
Copy link
Author

gar1t commented Apr 13, 2012

Yuri - you want to close this pull request? I can resubmit.

@yrashk
Copy link
Member

yrashk commented Apr 13, 2012

@gar1t any chance you can extract smaller bits of it and lets go one by one?

Also, wrt to rcvmore 0/1 vs false/true. I think this is a good change, but there's a lot of software already relying on 0/1. Should we work around that somehow?

@benoitc
Copy link

benoitc commented May 5, 2012

I had a look at this patch and was thinking we could have a recv_parts(Socket) in the main erlzmq object. Same for a send_parts thing. thoughts ?

@gar1t
Copy link
Author

gar1t commented May 5, 2012

Definitely need this. I have it laying around somewhere in my fork.

I've been very lazy in getting sync'd up with upstream :(

Benoit, IIRC you got the last round in San Fran, so I'll do this! I
can't get to it until later next week though.

On Sat, May 5, 2012 at 5:00 AM, Benoit Chesneau
[email protected]
wrote:

I had a look at this patch and was thinking we could have a recv_parts(Socket) in the main erlzmq object. Same for a send_parts thing. thoughts ?


Reply to this email directly or view it on GitHub:
#21 (comment)

Garrett Smith added 2 commits January 23, 2013 15:48
Specifically, fixes this error:

configure.in:13: error: 'AM_CONFIG_HEADER': this macro is obsolete.
    You should use the 'AC_CONFIG_HEADERS' macro instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants