Skip to content

Commit

Permalink
#include <winioctl.h> as MSDN prescribes (facebook#9612)
Browse files Browse the repository at this point in the history
Summary:
The recommendation can be found e. g. [here](https://docs.microsoft.com/en-us/windows/win32/api/winioctl/ns-winioctl-storage_property_query).

While `<windows.h>` transitively includes `<winioctl.h>` by default, this can be switched off by `/DWIN32_LEAN_AND_MEAN` which forces the user to include-what-you-use.

Pull Request resolved: facebook#9612

Reviewed By: riversand963

Differential Revision: D34845629

Pulled By: ajkr

fbshipit-source-id: 1ef9273074e3d84864c6833a7de6eb9df81e29d9
  • Loading branch information
georgthegreat authored and ajkr committed Mar 29, 2022
1 parent 9f0a64c commit 7629bf1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion port/win/env_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

#if defined(OS_WIN)

#include "port/win/env_win.h"

#include <direct.h> // _rmdir, _mkdir, _getcwd
#include <errno.h>
#include <io.h> // _access
Expand All @@ -17,6 +19,7 @@
#include <sys/stat.h>
#include <sys/types.h>
#include <windows.h>
#include <winioctl.h>

#include <algorithm>
#include <ctime>
Expand All @@ -27,7 +30,6 @@
#include "monitoring/thread_status_util.h"
#include "port/port.h"
#include "port/port_dirent.h"
#include "port/win/env_win.h"
#include "port/win/io_win.h"
#include "port/win/win_logger.h"
#include "rocksdb/env.h"
Expand Down

0 comments on commit 7629bf1

Please sign in to comment.