x86_64: begin rewriting instruction selection - #22386
Merged
Merged
Conversation
jacobly0
force-pushed
the
x86_64-rewrite
branch
4 times, most recently
from
January 5, 2025 08:07
78c2313 to
e1dfea3
Compare
|
comically large pr |
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
January 8, 2025 14:51
e1dfea3 to
e612e03
Compare
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
January 8, 2025 20:14
e612e03 to
ff1282e
Compare
jacobly0
force-pushed
the
x86_64-rewrite
branch
6 times, most recently
from
January 16, 2025 09:58
6d7d21a to
d160eba
Compare
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
January 16, 2025 19:58
d160eba to
124e2d9
Compare
The temp usage was non-obvious, and implicit instructions hard to reason about.
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
January 17, 2025 01:49
124e2d9 to
8c8dfb3
Compare
jacobly0
marked this pull request as ready for review
January 17, 2025 02:21
Member
|
Wow, congrats! |
andrewrk
approved these changes
Jan 17, 2025
andrewrk
left a comment
Member
There was a problem hiding this comment.
Incredible. I didn't realize just how much went into this branch until now when I reviewed it (locally of course since GitHub can't be bothered to display the diff).
The cg.select abstraction is pretty nifty.
Happy to see this land in master branch.
andrewrk
enabled auto-merge
January 17, 2025 04:32
Member
|
perf data point: building hello world |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21950