glibc: guard more function declarations #22771
Merged
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootbeer
reviewed
Feb 6, 2025
There was a problem hiding this comment.
I checked the version guards with the release notes, and they all look good. Your commit summary mentions close_range is in v2.36, but the diff and the truth are v2.34.
While reading the v2.39 release notes, I noticed pidfd_spawn and pidfd_spawnp were also added (in lib/libc/include/generic-glibc/bits/spawn_ext.h), if you want to cover a couple more while you're here ... But feel free to leave these for later/never.
I'm not a deputized reviewer, so feel free to ignore me.
chouquette
force-pushed
the
chouquette/glibc_guard
branch
from
13fc810 to
04bd6ed
Compare
It is only available starting from glibc 2.34
It was added in glibc 2.28
chouquette
force-pushed
the
chouquette/glibc_guard
branch
from
04bd6ed to
2c59b3b
Compare
|
Thank you both for your reviews! All comments should be addressed now |
rootbeer
reviewed
Feb 6, 2025
chouquette
force-pushed
the
chouquette/glibc_guard
branch
from
2c59b3b to
edee702
Compare
rootbeer
reviewed
Feb 6, 2025
alexrp
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard the declaration of:
close_range(introduced in 2.34)statx(introduced in 2.28)fsopen,fsmount,move_mount,fsconfig,fspick,open_tree,mount_setattr(introduced in 2.36)pidfd_open,pidfd_getfd,pidfd_send_signal(introduced in `2.36)pidfd_getpid(introduced in 2.39)This fixes building util-linux
while targeting glibc2.17` (or any version prior to 2.39)