detect invalid @bitCast with arrays
#25564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
requested changes
Oct 14, 2025
There was a problem hiding this comment.
One nitpick, sorry.
Aside from that... I don't think this is exactly the right check, but the eventual implementation of #19755 will iron out those semantics, and this is definitely an improvement on master, so I'm happy with it for now.
xdBronch
force-pushed
the
push-mxkvnsrqqvzy
branch
from
6fe01a5 to
09a2fa4
Compare
xdBronch
force-pushed
the
push-mxkvnsrqqvzy
branch
from
09a2fa4 to
6fad7e0
Compare
mlugg
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19405
closes #23673