Skip to content

Use manufacturer ID override for Sonoff ZBminiR2 #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

AnatolyRugalev
Copy link

This PR updates zbminir2 to use new manufacturer id override. Cleaning things up before adding missing attributes to this quirk.

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (81108c4) to head (9483dbf).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4084      +/-   ##
==========================================
+ Coverage   91.20%   91.21%   +0.01%     
==========================================
  Files         335      335              
  Lines       10889    10885       -4     
==========================================
- Hits         9931     9929       -2     
+ Misses        958      956       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnatolyRugalev AnatolyRugalev changed the title fix(zbminir2): implement hack zbminir2: use manufacturer ID override May 21, 2025
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just to confirm, you did test this with a physical device and it still works as expected?

@TheJulianJES TheJulianJES changed the title zbminir2: use manufacturer ID override Use manufacturer ID override for Sonoff ZBminiR2 May 22, 2025
@TheJulianJES TheJulianJES added code quality Improvement to code quality smash This PR is close to be merged soon labels May 22, 2025
@AnatolyRugalev
Copy link
Author

Just to confirm, you did test this with a physical device and it still works as expected?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality smash This PR is close to be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants