Skip to content

Conversation

@TheJulianJES
Copy link
Collaborator

Proposed change

@MattWestb mentioned the IKEA TRETAKT plugs support disabling LED and child lock as well, so this PR adds support for it.

Additional information

Follow-up to #4425
Reference: #4425 (comment)

Device diagnostics

Would be ideal if they can provided as well, so we can add them to our ZHA diagnostics tests.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@TheJulianJES TheJulianJES changed the title Move IKEA TRETAKT model to INSPELNING quirk Add IKEA Tretakt child lock and LED disable functionality Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (d240b1f) to head (8a34157).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4438   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         363      363           
  Lines       11978    11978           
=======================================
  Hits        11040    11040           
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# remove LevelControl for plugs to not show config options in ZHA
(
QuirkBuilder(IKEA, "INSPELNING Smart plug")
.applies_to(IKEA, "TRETAKT Smart plug")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: also_applies_to is the same as applies_to. The different naming is due to quirk builders being allowed to be created without any manufacturer/model info now, so the "also" doesn't make sense in those case.

Doesn't really matter. They're both the same for now.

@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label Oct 28, 2025
@TheJulianJES TheJulianJES merged commit a17af7a into zigpy:dev Oct 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

smash This PR is close to be merged soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant