Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aqara H1 with neutral features #370

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

krakonos1602
Copy link

This PR implements handling of Do not disturb mode, Decoupled mode, Power outage memory and Reversed LEDs switches present in Aqara H1 with neutral ("lumi.switch.n1aeu1", "lumi.switch.n2aeu1") wall switches.

Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely wanna implement these as quirks v2 entities (in the zha-device-handlers repo).
The quirk might need to be updated from a v1 to a v2 quirk first.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.58%. Comparing base (8fd7bc5) to head (0ef8b7c).

Files with missing lines Patch % Lines
...ha/zigbee/cluster_handlers/manufacturerspecific.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #370      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files          61       61              
  Lines        9526     9550      +24     
==========================================
+ Hits         9201     9224      +23     
- Misses        325      326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krakonos1602
Copy link
Author

We likely wanna implement these as quirks v2 entities (in the zha-device-handlers repo). The quirk might need to be updated from a v1 to a v2 quirk first.

Sorry, I have no idea of v1 vs v2 quirks and entities. I just needed to make these switches work.

@TheJulianJES
Copy link
Contributor

Let's leave this open for now, so we can track it.
But you should already be able to change the values via the "Manage Zigbee device" -> Clusters menu, even without these changes.

@TheJulianJES TheJulianJES marked this pull request as draft January 29, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants