Skip to content

Add WindSpeed sensor, add UnitOfSpeed #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025

Conversation

P-R-O-C-H-Y
Copy link
Contributor

@P-R-O-C-H-Y P-R-O-C-H-Y commented Mar 24, 2025

This PR adds default native support for WindSpeed sensor and a UnitOfSpeed.

@puddly PTAL and let me know if I should provide device description for testing. I don't have a testing environment setup so this PR is not tested.

Related #398

P-R-O-C-H-Y and others added 2 commits March 24, 2025 12:33
P-R-O-C-H-Y and others added 2 commits March 24, 2025 15:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: puddly <[email protected]>
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (9aaa2ac) to head (72e4ac9).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #401   +/-   ##
=======================================
  Coverage   96.67%   96.68%           
=======================================
  Files          61       61           
  Lines        9813     9834   +21     
=======================================
+ Hits         9487     9508   +21     
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added the entities Issue or PR about (custom) entities label Mar 24, 2025
@TheJulianJES TheJulianJES changed the title Add UnitofSpeed and WindSpeed sensor handler Add WindSpeed sensor, add UnitOfSpeed Mar 24, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from puddly March 25, 2025 08:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
P-R-O-C-H-Y and others added 2 commits March 26, 2025 14:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@puddly puddly merged commit 07197ac into zigpy:dev Mar 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Issue or PR about (custom) entities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants