Improve cover state restoration from the HA entity cache #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #412 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 61 61
Lines 9987 9992 +5
=======================================
+ Hits 9655 9660 +5
Misses 332 332 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeverley
changed the title
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
1e4e331 to
8b15410
Compare
jeverley
changed the title
puddly
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
11609df to
8a251dd
Compare
Contributor
|
I've rebased this PR on top of |
Contributor
Author
Thanks @puddly, this one should be ready for review now too. |
puddly
reviewed
Apr 23, 2025
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
a15538a to
765324b
Compare
…e HA cache This adds a timeout for movement states restored from the entity cache. Uses zigpy#410 as a base.
…vice has already reached the movement extrema - Updates tests to use a common mock cover device creation function to reduce code repetition
- We init `_state` with None and let the `_determine_cover_state` function populate the value from current positions - Ensures all lines are coverable by tests
… upon entity removal
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
0d55d6a to
27cda67
Compare
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
2 times, most recently
from
f86216b to
1a28055
Compare
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
fb0abe2 to
ff977f0
Compare
…termine_cover_position` function
jeverley
force-pushed
the
cover-correctly-handle-restore-of-movement-state
branch
from
7d7f656 to
28429be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
This PR handles edge cases in restoring state after ZHA has been offline.
The current behaviour results in the cover stuck in a restored
OPENING/CLOSINGstate until the device reports a position update (could be up to 5 mins with some devices).We also currently restore open/closed state regardless of the device's actual position.
The below changes have been made to handle state restoration correctly
CLOSING/OPENINGstatesCLOSED/completelyOPEN(i.e. 100%)CLOSED/OPENstates, instead the state is determined from current position during initOther improvements
Updates to cover tests