Skip to content

Also test quirks v2 command button command_kwargs #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
+43 −7
Draft

Also test quirks v2 command button command_kwargs #556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c688c0
Change command button test to use `command_kwargs`
TheJulianJES Oct 28, 2025
8e93cac
Test both command args and kwargs with `parametrize`
TheJulianJES Oct 28, 2025
cb02c73
Remove `_Call` type
TheJulianJES Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 43 additions & 7 deletions tests/test_button.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,17 @@ async def custom_button_device(zha_gateway: Gateway):
FakeManufacturerCluster.ServerCommandDefs.self_test.name,
FakeManufacturerCluster.cluster_id,
command_args=(5,),
translation_key="self_test",
fallback_name="Self test",
unique_id_suffix="self_test_args",
translation_key="self_test_args",
fallback_name="Self test args",
)
.command_button(
FakeManufacturerCluster.ServerCommandDefs.self_test.name,
FakeManufacturerCluster.cluster_id,
command_kwargs={"identify_time": 5},
unique_id_suffix="self_test_kwargs",
translation_key="self_test_kwargs",
fallback_name="Self test kwargs",
)
.write_attr_button(
FakeManufacturerCluster.AttributeDefs.feed.name,
Expand All @@ -249,14 +258,43 @@ async def custom_button_device(zha_gateway: Gateway):
return zha_device, zigpy_device.endpoints[1].mfg_identify


@pytest.mark.parametrize(
("qualifier", "request_call"),
[
(
"self_test_args",
call(
False,
0,
FakeManufacturerCluster.ServerCommandDefs.self_test.schema,
5,
manufacturer=4151,
expect_reply=True,
tsn=None,
),
),
(
"self_test_kwargs",
call(
False,
0,
FakeManufacturerCluster.ServerCommandDefs.self_test.schema,
manufacturer=4151,
expect_reply=True,
tsn=None,
identify_time=5,
),
),
],
)
async def test_quirks_command_button(
zha_gateway: Gateway,
zha_gateway: Gateway, qualifier: str, request_call
) -> None:
"""Test ZHA button platform."""
zha_device, cluster = await custom_button_device(zha_gateway)
assert cluster is not None
entity: PlatformEntity = get_entity(
zha_device, platform=Platform.BUTTON, entity_type=Button
zha_device, platform=Platform.BUTTON, entity_type=Button, qualifier=qualifier
)

with patch(
Expand All @@ -266,9 +304,7 @@ async def test_quirks_command_button(
await entity.async_press()
await zha_gateway.async_block_till_done()
assert len(cluster.request.mock_calls) == 1
assert cluster.request.call_args[0][0] is False
assert cluster.request.call_args[0][1] == 0
assert cluster.request.call_args[0][3] == 5 # duration in seconds
assert cluster.request.mock_calls[0] == request_call


async def test_quirks_write_attr_button(
Expand Down
Loading