Add get_mint_timestamp read method - #323
Merged
Merged
Conversation
- Adds get_mint_timestamp to queries, returning the ledger timestamp of a wrap mint for a given user and period as an Option<u64>. - Adds tests covering both the value exists and value missing cases in src/test.rs.
|
@Daverisky-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281 - Add get_mint_timestamp read method
Summary
This PR adds a read method to return the mint timestamp for a given user-period as an
Option<u64>, resolving issue #281.Acceptance Criteria
get_mint_timestamp(e: Env, user: Address, period: u64) -> Option<u64>.test_get_mint_timestamp_existsandtest_get_mint_timestamp_missingtesting both scenarios insrc/test.rs.Noneif no mint has occurred.Notes for Reviewers
cargo test) failed to compile prior to these changes due to a dependency resolution error insoroban-env-hostv21.2.1 (ChaCha20Rng: ed25519_dalek::rand_core::CryptoRngtrait bound not satisfied). The changes introduced here follow existing storage patterns and should be structurally sound once the dependency tree compiles.u64based on the existingWrapRecord { timestamp: u64 }struct implementation.src/mint.rsregarding manual range bounds were left untouched as they were out of scope.