fix: resolve format check

zjregee · Aug 15, 2024 · c75ff81 · c75ff81
1 parent ada9d16
commit c75ff81
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 15 deletions.
diff --git a/ahttp/binder_test.go b/ahttp/binder_test.go
@@ -10,15 +10,15 @@ func TestBinderBindHeaders(t *testing.T) {
 	c := newTestContextWithJson()
 	b := &DefaultBinder{}
 	bindData := map[string]string{}
-	b.BindHeaders(bindData, c)
+	_ = b.BindHeaders(bindData, c)
 	assert.Equal(t, MIMEApplicationJSON, bindData["Content-Type"])
 }
 
 func TestBinderBindQueryParams(t *testing.T) {
 	c := newTestContextWithJson()
 	b := &DefaultBinder{}
 	bindData := map[string]string{}
-	b.BindQueryParams(bindData, c)
+	_ = b.BindQueryParams(bindData, c)
 	assert.Equal(t, "test", bindData["name"])
 	assert.Equal(t, "18", bindData["age"])
 }
@@ -27,7 +27,7 @@ func TestBinderBindBodyJson(t *testing.T) {
 	c := newTestContextWithJson()
 	b := &DefaultBinder{}
 	bindData := &testJsonData{}
-	b.BindBody(bindData, c)
+	_ = b.BindBody(bindData, c)
 	assert.Equal(t, "test", bindData.Name)
 	assert.Equal(t, 18, bindData.Age)
 }
@@ -36,7 +36,7 @@ func TestBinderBindBodyForm(t *testing.T) {
 	c := newTestContextWithForm()
 	b := &DefaultBinder{}
 	bindData := map[string]string{}
-	b.BindBody(bindData, c)
+	_ = b.BindBody(bindData, c)
 	assert.Equal(t, "test", bindData["name"])
 	assert.Equal(t, "18", bindData["age"])
 }
diff --git a/connection_impl.go b/connection_impl.go
@@ -270,7 +270,7 @@ func (c *connection) waitReadUntil(delim byte) ([]byte, error) {
 				}
 			}
 			if index != -1 {
-				c.inputBuffer.SeekAck(index + 1)
+				_ = c.inputBuffer.SeekAck(index + 1)
 				return data[:index+1], nil
 			}
 		}

diff --git a/connection_reactor.go b/connection_reactor.go
@@ -5,12 +5,12 @@ const (
 )
 
 func (c *connection) onRead(n int, err error) {
-	c.inputBuffer.BookAck(n)
+	_ = c.inputBuffer.BookAck(n)
 	c.readTrigger <- err
 }
 
 func (c *connection) onWrite(n int, err error) {
-	c.outputBuffer.SeekAck(n)
+	_ = c.outputBuffer.SeekAck(n)
 	c.writeTrigger <- err
 }
 

diff --git a/e2e_test/echo_server/echo_server.go → e2e_test/tcp_server/tcp_server.go b/e2e_test/echo_server/echo_server.go → e2e_test/tcp_server/tcp_server.go
@@ -1,4 +1,4 @@
-package echoserver
+package tcpserver
 
 import (
 	"context"
@@ -16,11 +16,13 @@ func runServer(port string, stopChan chan interface{}) {
 	if err != nil {
 		panic("shouldn't failed here")
 	}
-	go eventLoop.Serve(listener)
+	go func() {
+		_ = eventLoop.Serve(listener)
+	}()
 
 	go func() {
 		<-stopChan
-		eventLoop.Shutdown(context.Background())
+		_ = eventLoop.Shutdown(context.Background())
 		listener.Close()
 	}()
 }

diff --git a/e2e_test/echo_server/echo_server_test.go → e2e_test/tcp_server/tcp_server_test.go b/e2e_test/echo_server/echo_server_test.go → e2e_test/tcp_server/tcp_server_test.go
@@ -1,4 +1,4 @@
-package echoserver
+package tcpserver
 
 import (
 	"bufio"
@@ -11,7 +11,7 @@ import (
 	"github.com/zjregee/anet"
 )
 
-func TestEchoServerSerial(t *testing.T) {
+func TestTCPServerSerial(t *testing.T) {
 	port := ":8001"
 	stopchan := make(chan interface{})
 	runServer(port, stopchan)
@@ -46,7 +46,7 @@ func TestEchoServerSerial(t *testing.T) {
 	}
 }
 
-func TestEchoServerConcurrent(t *testing.T) {
+func TestTCPServerConcurrent(t *testing.T) {
 	port := ":8002"
 	stopchan := make(chan interface{})
 	runServer(port, stopchan)

diff --git a/ring_manager.go b/ring_manager.go
@@ -22,7 +22,7 @@ type roundRobinLB struct {
 }
 
 func (b *roundRobinLB) Pick() (ring Ring) {
-	if b.rings == nil || len(b.rings) == 0 {
+	if len(b.rings) == 0 {
 		return nil
 	}
 	index := int(atomic.AddInt32(&b.lastpicked, 1)) % len(b.rings)
@@ -55,7 +55,9 @@ func (m *manager) Run() error {
 			errs = append(errs, err)
 			log.Warnf("error occurred while open ring")
 		} else {
-			go ring.Wait()
+			go func() {
+				_ = ring.Wait()
+			}()
 			rings = append(rings, ring)
 		}
 	}