Skip to content

Revert "Staging"#6

Merged
zkbkb merged 1 commit intomainfrom
revert-5-staging
Jul 26, 2025
Merged

Revert "Staging"#6
zkbkb merged 1 commit intomainfrom
revert-5-staging

Conversation

@zkbkb
Copy link
Copy Markdown
Owner

@zkbkb zkbkb commented Jul 26, 2025

User description

Reverts #5


PR Type

Other


Description

  • Reverts staging changes from PR Staging #5

  • Removes version management and build infrastructure

  • Eliminates test scripts and GitHub workflows

  • Simplifies project to basic functionality


Diagram Walkthrough

flowchart LR
  A["Staging PR #5"] --> B["Version System"]
  A --> C["Build Scripts"]
  A --> D["GitHub Workflows"]
  A --> E["ESLint Config"]
  B --> F["Reverted"]
  C --> F
  D --> F
  E --> F
Loading

File Walkthrough

Relevant files

This reverts commit 8257e3f.
@zkbkb zkbkb merged commit dc7862c into main Jul 26, 2025
1 check passed
@zkbkb zkbkb deleted the revert-5-staging branch July 26, 2025 02:19
@qodo-code-review
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dependency Issue

The go.mod file shows inconsistent dependency management where required dependencies are moved to indirect comments, which could break the build or cause import issues.

require (
	github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
	github.com/briandowns/spinner v1.23.2 // indirect
	github.com/charmbracelet/bubbles v0.21.0 // indirect
	github.com/charmbracelet/bubbletea v1.3.5 // indirect
	github.com/charmbracelet/colorprofile v0.2.3-0.20250311203215-f60798e515dc // indirect
	github.com/charmbracelet/harmonica v0.2.0 // indirect
	github.com/charmbracelet/lipgloss v1.1.0 // indirect
	github.com/charmbracelet/x/ansi v0.8.0 // indirect
	github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
	github.com/charmbracelet/x/term v0.2.1 // indirect
	github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f // indirect
	github.com/fatih/color v1.7.0 // indirect
	github.com/fsnotify/fsnotify v1.9.0 // indirect
	github.com/inconshreveable/mousetrap v1.1.0 // indirect
	github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
	github.com/mattn/go-colorable v0.1.2 // indirect
	github.com/mattn/go-isatty v0.0.20 // indirect
	github.com/mattn/go-localereader v0.0.1 // indirect
	github.com/mattn/go-runewidth v0.0.16 // indirect
	github.com/muesli/ansi v0.0.0-20230316100256-276c6243b2f6 // indirect
	github.com/muesli/cancelreader v0.2.2 // indirect
	github.com/muesli/termenv v0.16.0 // indirect
	github.com/rivo/uniseg v0.4.7 // indirect
	github.com/spf13/cobra v1.9.1 // indirect
	github.com/spf13/pflag v1.0.6 // indirect
	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
	golang.org/x/sync v0.13.0 // indirect
	golang.org/x/sys v0.32.0 // indirect
Build Error

The workflow references non-existent Go files in the build command that were likely removed in the revert, which will cause the build to fail.

  go build -ldflags="-s -w" -o git-status-dash-go-${{ matrix.goos }}-${{ matrix.goarch }}.exe main.go animations.go hacker_effects.go performance.go
else
  go build -ldflags="-s -w" -o git-status-dash-go-${{ matrix.goos }}-${{ matrix.goarch }} main.go animations.go hacker_effects.go performance.go
fi

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @zkbkb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of a prior 'Staging' branch, aiming to roll back changes that introduced specific development tooling, build processes, and documentation elements. The primary objective appears to be a cleanup or simplification of the project's configuration and operational scope by undoing these previously staged modifications.

Highlights

  • Reversion of Staging Changes: This pull request fully reverts the changes introduced in zkbkb/git-status-dash#5, which was titled "Staging". This action effectively undoes the additions and modifications made in that previous PR.
  • Removal of Development Tooling: The project's JavaScript linting setup has been removed, including the .eslintrc.json file, eslint as a development dependency, and associated linting scripts from package.json. Additionally, the test-release.sh script has been removed.
  • Go Module and Versioning Adjustments: Go module dependencies in go.mod and go.sum have been refactored, moving some from direct requirements to indirect. Explicit versioning logic for the Go application was also removed from main.go.
  • Repository Scanning Behavior Change: The index.mjs file's list of directories to skip during repository scanning has been reduced. This means directories like target, build, dist, .next, .nuxt, and vendor will now be included in scans, altering the tool's operational scope.
  • Documentation Cleanup: Several CI/release badges have been removed from the README.md file, simplifying the project's main documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@qodo-code-review
Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Restore version field functionality

The removal of the Version field from the cobra command will prevent users from
checking the application version. This is a critical functionality loss that
should be restored to maintain proper version reporting capabilities.

main.go [61-68]

 rootCmd := &cobra.Command{
 	Use:   "git-status-dash [directory]",
 	Short: "Monitor git repository status in real-time",
 	Long: `Git Status Dashboard recursively scans directories for git repositories
 and displays their status with beautiful TUI or report output.`,
-	Args: cobra.MaximumNArgs(1),
-	Run:  run,
+	Args:    cobra.MaximumNArgs(1),
+	Version: "dev",
+	Run:     run,
 }

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly points out that removing the Version field from the cobra.Command is a significant functionality loss for a command-line tool, and the proposed change restores this capability.

Medium
  • More

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts changes from PR #5, simplifying the project by removing versioning, build, and CI/CD infrastructure. The changes are largely consistent with this goal.

I've identified a few issues that have been introduced as part of this revert:

  • The .gitignore file no longer ignores the test-build/ and .vscode/ directories, which could lead to committing build artifacts and editor-specific settings.
  • In index.mjs, the list of skipped directories for scanning has been reduced, which might negatively impact performance.
  • There's also a minor issue of an unused variable in index.mjs.

Please review the detailed comments for suggestions on how to address these points.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 5, 2025
Learn more in the Cursor dashboard.

go build -ldflags="-s -w" -o git-status-dash-go-${{ matrix.goos }}-${{ matrix.goarch }}.exe main.go animations.go hacker_effects.go performance.go
else
go build -ldflags="-s -w" -o git-status-dash-go-${{ matrix.goos }}-${{ matrix.goarch }} main.go animations.go hacker_effects.go performance.go
fi
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Go Build Omitting Required Files

The go build command in the release-go job explicitly lists source files, omitting config.go and themes.go which are required for a complete build (as indicated by package.json). This will lead to compilation errors. The command should instead use go build . to automatically include all package files and also incorporate version injection.

Locations (1)

Fix in CursorFix in Web

github.com/muesli/cancelreader v0.2.2 // indirect
github.com/muesli/termenv v0.16.0 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
github.com/spf13/cobra v1.9.1 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Go Module Dependency Marking Error

Direct dependencies, such as github.com/spf13/cobra, github.com/charmbracelet/bubbletea, github.com/charmbracelet/lipgloss, and github.com/fsnotify/fsnotify, are incorrectly marked as // indirect in go.mod. As these packages are directly imported by the application, this violates Go module semantics and can lead to module resolution or build failures.

Locations (1)

Fix in CursorFix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant