Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uninitialized AND gate in email regex circuit
Bug
The email regex circuit was failing due to uninitialized AND gates caused by epsilon transitions (empty character set transitions) in the DFA. These epsilon transitions were created from optional patterns (
?
) and zero-or-more quantifiers (*
) in the regex.Fix
Added
remove_epsilon_transitions
function to clean the DFA graph by removing transitions with empty character sets before circuit generation. This ensures all AND gates in the resulting circuit have proper inputs.Testing
dfa_tests.json
\r\n
and^
anchorsImpact
This fix makes the email regex circuit more reliable by eliminating uninitialized gates while maintaining the same matching behavior.