Add ONNX example: PLA Sigmoid (replace lookup with piecewise linear)#1021
Draft
changshenhan wants to merge 1 commit into
Draft
Add ONNX example: PLA Sigmoid (replace lookup with piecewise linear)#1021changshenhan wants to merge 1 commit into
changshenhan wants to merge 1 commit into
Conversation
…ter, faster proving
Author
|
Hi @jasonmorton and @zkonduit-team, I've submitted this PR to implement the Piecewise Linear Approximation (PLA) for Sigmoid, which significantly optimizes the proof generation time. It's been a few days and the CI workflows are still awaiting approval. Could you please help to run the workflows so I can ensure everything passes on your side? I've already verified the logic locally with a precision of 99.5%. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an ONNX example under
examples/onnx/pla_sigmoidthat replaces Sigmoid lookup with a piecewise linear approximation (PLA). The circuit uses only mul/add/compare (copy and arithmetic constraints), no lookup.num_inner_cols=1, minimallookup_range).Author: @changshenhan