Fix division by zero vulnerability in graph utilities multiplication optimization#999
Open
gap-editor wants to merge 1 commit into
Open
Fix division by zero vulnerability in graph utilities multiplication optimization#999gap-editor wants to merge 1 commit into
gap-editor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical logical error that could cause runtime panics due to division by zero in the graph utilities module.
Problem
In
src/graph/utilities.rsat line 1055, the code performs division1.0 / c.raw_values[0]after only checking thatc.raw_values[0] < 1.0. This condition allowsc.raw_values[0]to be exactly0.0, which would cause a division by zero panic at runtime.Solution
Added an explicit check
&& c.raw_values[0] != 0.0to the existing conditional to ensure the division operation is only performed when the divisor is guaranteed to be non-zero.