Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better name brackets #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ngavinsir
Copy link

resolves #100

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for zmk-studio ready!

Name Link
🔨 Latest commit 9109134
🔍 Latest deploy log https://app.netlify.com/sites/zmk-studio/deploys/67504c482930ac0008f9e4f4
😎 Deploy Preview https://deploy-preview-101.preview.zmk.studio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this file is generated from a generated file from the USB-IF, we probably don't want to edit it directly. Can you add these changes to the override file instead? I agree that these names are not as accurate, but they do come from the USB HID tables https://usb.org/document-library/hid-usage-tables-15

@tanant
Copy link

tanant commented Jan 12, 2025

@Nicell - is https://github.com/zmkfirmware/zmk-studio/blob/main/src/HidUsageTables-1.5.json the dump from USB-IF? I had a read through the PDF spec and it's just got the literal symbols, but if that's the correct source I might have a look through it and see if there's other things where they've made a decision to name a symbol in a way that might not be ideal.

@petejohanson
Copy link
Collaborator

@Nicell - is https://github.com/zmkfirmware/zmk-studio/blob/main/src/HidUsageTables-1.5.json the dump from USB-IF? I had a read through the PDF spec and it's just got the literal symbols, but if that's the correct source I might have a look through it and see if there's other things where they've made a decision to name a symbol in a way that might not be ideal.

The PDF spec has that file as an attachment in the PDF (a feature I didn't know existed before finding it). You want to add overrides to https://github.com/zmkfirmware/zmk-studio/blob/main/src%2Fhid-usage-name-overrides.json instead.

@tanant
Copy link

tanant commented Jan 12, 2025

omg... it's in the pdf?? I've been doing a scan through and can't find it but given that i didn't even think to look there I'm not surprised if my brain just doesn't work in the same way.

(i'll go and do a PR in a bit, found one that I hit around Return and Return Enter 😑 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better name for the { [ ( symbol
4 participants