wrapper: soft load state, add details to prints #135
+51
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litlep-nibbyt
commented
Feb 3, 2025
| =/ o ((soft input) input.u.ovum) | ||
| ?~ o | ||
| ~& "could not mold poke type: {<ovum>}" | ||
| =+ (road |.(;;(^^ovum ovum))) |
There was a problem hiding this comment.
this prints out stack trace if soft fails
litlep-nibbyt
commented
Feb 3, 2025
apps/choo/bootstrap/kernel.hoon
Outdated
| ^- choo-state | ||
| ?+ -.arg ~& >> %no-upgrade arg | ||
| ?~ ((soft versioned-state) old) | ||
| ~& >> "choo: +load old state does not nest under versioned-state" !! |
There was a problem hiding this comment.
add road here to get stack trace
wrapper: soft load state wrapper: add more details to poke prints
litlep-nibbyt
force-pushed
the
jyw/soft-load
branch
from
dbe2ab9 to
4a3c52e
Compare
litlep-nibbyt
commented
Feb 3, 2025
| @@ -28,7 +28,9 @@ pub use drivers::exit::exit as exit_driver; | |||
| pub use drivers::file::file as file_driver; | |||
| pub use drivers::http::http as http_driver; | |||
| pub use drivers::markdown::markdown as markdown_driver; | |||
| pub use drivers::npc::{npc_client as npc_client_driver, npc_listener as npc_listener_driver}; | |||
| pub use drivers::npc::{ | |||
| npc_client as npc_client_driver, npc_listener as npc_listener_driver, NpcWire, | |||
There was a problem hiding this comment.
expose NpcWire for outside use
ryjm
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init tracing before setup to receive setup prints
soft load state in inner kernels
wrapper: add more details to poke prints
separate PR needs to be made to change load behavior in NockApp Kernel struct to "soft" load and print formatted stack trace in the case of failure.