[DO NOT MERGE] Improved generic translation #1897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolz
reviewed
Mar 6, 2019
Generic.js
Outdated
| } | ||
|
|
||
| /** BEGIN TEST CASES **/ | ||
| var testCases = []; |
There was a problem hiding this comment.
It'd be helpful to have test cases here.
|
What is the status/plan for this PR which relies on the new functions for JSON-LD in |
AbeJellinek
force-pushed
the
improved-generic-translation
branch
from
7e61141 to
b6b8c50
Compare
Not sure about this, but headDois wasn't being used at all before.
AbeJellinek
reviewed
Mar 21, 2024
|
OK, this is working well enough to test with zotero/zotero#2894 and zotero/utilities#20 checked out. |
EM tends to detect 'webpage' for non-webpage items, so this doesn't work perfectly yet.
- Don't detect in generic translators unless called from Generic - Fix detection code - Fix multiples code - Add logging - Don't use Zotero.done() in EM - Detect more accurately in LM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.