Skip to content

make the assert work with numpy integers #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rlucas7
Copy link

@rlucas7 rlucas7 commented May 16, 2025

  • currently when I try to run the example demo-ing prompt optimizer I get a failure that np.int64 is not an accepted input type for Value. This pr changes the assertion to accept that input type for ints. After making the change locally I am able to run the quick start code successfully.

  * currently when I try to run the
  example demo-ing prompt optimizer
  I get a failure that np.int64 is not
  an accepted input type for Value. This
  pr changes the assertion to accept that
  input type for ints. After making the
  change locally I am able to run the
  quick start code successfully.
@rlucas7 rlucas7 requested review from vinid and mertyg as code owners May 16, 2025 23:08
@rlucas7
Copy link
Author

rlucas7 commented May 17, 2025

So I hadn't seen the multimodal workflows as a use case.

I found the test harness command from some of the other PRs w/a green check.
I ran the tests on this branch:

and the multimodal test at that line fails whereas it passes on the current time of main bf5b0c5 so I'm not sure what is the best way to proceed here. If the intent is to not have numpy ints as inputs then we can close this, but if there is something that needs to be changed for the multimodal stuff please LMK. In my current project I'm working with text only (natural language and programming languages).

To be clear, to execute tests locally I'm running:

pytest --ignore=tests/test_api.py --ignore=tests/test_litellm_engine_functional.py --ignore=tests/test_litellm_engine_parameters_and_caching.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant