Skip to content

refactor: Include Caching service in the Modulith #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 113 commits into from
Jul 17, 2025
Merged

refactor: Include Caching service in the Modulith #4190

merged 113 commits into from
Jul 17, 2025

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Jun 30, 2025 •
edited by pablocarle
Loading

Description

Include Caching service as part of Spring Modulith API ML module.

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

achmelo and others added 28 commits June 24, 2025 13:22
@achmelo
convert to webflux
b15117d 
Signed-off-by: ac892247 <[email protected]>
@achmelo
set reactive app
003b200 
Signed-off-by: ac892247 <[email protected]>
@taban03
fix caching controller tests
510a145 
Signed-off-by: Andrea Tabone <[email protected]>
@achmelo
introduce interface
042706c 
Signed-off-by: ac892247 <[email protected]>
@achmelo
Merge remote-tracking branch 'origin/v3.x.x' into reboot/modulith-cac…
6c3a1d7 
…hing

# Conflicts:
#	apiml-tomcat-common/build.gradle
#	apiml-tomcat-common/src/main/java/org/zowe/apiml/filter/AttlsHttpHandler.java
@achmelo
reactive app for tests
94bcf56 
Signed-off-by: ac892247 <[email protected]>
@achmelo
successful start
a36e1d2 
Signed-off-by: ac892247 <[email protected]>
@achmelo
accept trailing slashes
31486b0 
Signed-off-by: ac892247 <[email protected]>
@taban03
fix tests
d7fd259 
Signed-off-by: Andrea Tabone <[email protected]>
@achmelo
move x509 utils to common package
9a7b55a 
Signed-off-by: ac892247 <[email protected]>
@achmelo
Merge remote-tracking branch 'origin/reboot/modulith-caching' into re…
3d59ccc 
…boot/modulith-caching
@achmelo
Merge remote-tracking branch 'origin/v3.x.x' into reboot/modulith-cac…
457f28b 
…hing

# Conflicts:
#	apiml/src/main/java/org/zowe/apiml/WebSecurityConfig.java
#	gateway-service/src/main/java/org/zowe/apiml/gateway/config/WebSecurity.java
#	gateway-service/src/main/java/org/zowe/apiml/gateway/filters/AbstractAuthSchemeFactory.java
@achmelo
caching in modulith initial run
8bbbdcd 
Signed-off-by: ac892247 <[email protected]>
@taban03
wip - create impl for the caching client for modulith
36d21bd 
Signed-off-by: Andrea Tabone <[email protected]>
@taban03
remove qualifier
81becc9 
Signed-off-by: Andrea Tabone <[email protected]>
@achmelo
working modulith
e580acf 
Signed-off-by: ac892247 <[email protected]>
@achmelo
Merge remote-tracking branch 'origin/reboot/modulith-caching' into re…
fb1ff22 
…boot/modulith-caching

# Conflicts:
#	caching-service/src/main/java/org/zowe/apiml/caching/api/CachingController.java
@achmelo
imports
5782056 
Signed-off-by: ac892247 <[email protected]>
@achmelo
move keyvalue to original package
02c11ec 
Signed-off-by: ac892247 <[email protected]>
@achmelo
add serial id
2518584 
Signed-off-by: ac892247 <[email protected]>
@achmelo
allow token type to serialize
d90a00f 
Signed-off-by: ac892247 <[email protected]>
@achmelo
service prefix for actuator
107d479 
Signed-off-by: ac892247 <[email protected]>
@achmelo
ignore enabler in modulith
37d5b1a 
Signed-off-by: ac892247 <[email protected]>
@achmelo
apidoc with prefix
3a30f62 
Signed-off-by: ac892247 <[email protected]>
@achmelo
fix typo
dc3e578 
Signed-off-by: ac892247 <[email protected]>
@achmelo
actuator endpoint with prefix
8df61c9 
Signed-off-by: ac892247 <[email protected]>
@achmelo
change order of security chains
9f29c83 
Signed-off-by: ac892247 <[email protected]>
@taban03
add license
9f1bd60 
Signed-off-by: Andrea Tabone <[email protected]>
achmelo added 2 commits July 15, 2025 10:28
@achmelo
fix test
a66db06 
Signed-off-by: ac892247 <[email protected]>
@achmelo
correct msg
cd95695 
Signed-off-by: ac892247 <[email protected]>
pj892031
pj892031 reviewed Jul 15, 2025
View reviewed changes
@achmelo
code review
574b300 
Signed-off-by: ac892247 <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@achmelo achmelo merged commit fea7570 into v3.x.x Jul 17, 2025
153 of 171 checks passed
@achmelo achmelo deleted the reboot/modulith-caching branch July 17, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarle pablocarle pablocarle left review comments

@achmelo achmelo achmelo left review comments

@pj892031 pj892031 pj892031 approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review size/XXL
Projects
API Mediation Layer Backlog Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taban03 @pablocarle @achmelo @pj892031