-
Notifications
You must be signed in to change notification settings - Fork 68
fix: Fix of Tomcat customizers to be supported also by reactive stuff #4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jareš <[email protected]>
Can you decribe the issue in the PR description? |
achmelo
reviewed
Oct 8, 2025
apiml-tomcat-common/src/main/java/org/zowe/apiml/product/web/TomcatKeyringFix.java
Show resolved
Hide resolved
I have added short description. |
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
achmelo
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to set infinispan log levels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original issue was when a customer configure zowe.yml to use keyring and provide the keyring URL with just douple slashes (not four). All services except the caching service fix the issue in Tomcat. The handler responsible to fixing URLs was not applied for the caching service, because the implementation is only for servlet implementation. Caching service and API catalog uses WebFlux. Therefor the handler was ignored and not applied. The workarround was to use 4 slashes. More information about the error itself is in the linked issue.
Linked to #4324
Type of change
Checklist: