Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues badge, update doc to remove web folder reference #260

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

davenice
Copy link
Contributor

@davenice davenice commented Mar 29, 2025

What It Does
Updates the readme to...

  • Fix the issues badge
  • Add a code coverage badge
  • Remove the reference to the web folder (doc catch up for Flattened Web resources #257) ... this was already mentioned in the change-log so I don't believe we need to change-log this

Updates the PR template to remind people to check the doc.

None of this affects the released product so there will be no need to ship a new version at this point.

Review Checklist
I certify that I have:

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.02%. Comparing base (c079d4c) to head (1d2e4bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files         153      153           
  Lines        5206     5206           
  Branches      884      883    -1     
=======================================
  Hits         2136     2136           
  Misses       3070     3070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davenice davenice changed the title Fix issues badge Fix issues badge, update doc to remove web folder reference Mar 29, 2025
@davenice davenice marked this pull request as ready for review March 29, 2025 20:09
@davenice davenice force-pushed the davenice-fix-issues-badge branch 2 times, most recently from c1d9b31 to 6b44eb7 Compare March 31, 2025 16:32
@davenice davenice force-pushed the davenice-fix-issues-badge branch from 6b44eb7 to 1d2e4bf Compare April 1, 2025 09:50
Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice GIF removal!!

Copy link
Contributor

@enamkhan enamkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davenice davenice merged commit dea05e7 into main Apr 1, 2025
21 checks passed
@davenice davenice deleted the davenice-fix-issues-badge branch April 1, 2025 10:37
@davenice davenice added the release-minor Indicates a minor feature has been added label Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-minor Indicates a minor feature has been added released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants