-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6940_April_2_SafKeyringConfigSlashes #4277
base: master
Are you sure you want to change the base?
Conversation
The following is mentioned: While migrating from Zowe v2.18, if you are using keyrings, verify that Zowe YAML references to `safkeyring` use 2 slashes, not 4, such as `safkeyring://` instead of `safkeyring:////`
😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.
Need help? Contact the Doc Squad in the #zowe-doc Slack channel. |
1 similar comment
😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.
Need help? Contact the Doc Squad in the #zowe-doc Slack channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of comments re: style.
@@ -34,6 +34,7 @@ To migrate from Zowe **v2.16.0** or a lower version, perform the following tasks | |||
|
|||
2) Update your PROCLIB entries for Zowe, as enhancements and default parameters have changed throughout Zowe v2. | |||
This can be performed with the unix command `zwe init stc`, by running the job ZWEISTC, or by copying the SZWESAMP members ZWESLSTC, ZWESISTC, and ZWESASTC into your desired PROCLIB. | |||
3) If you are using keyrings, verify that Zowe YAML references to `safkeyring` use 2 slashes, not 4, such as `safkeyring://` instead of `safkeyring:////`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should spell out 2 and 4. Typically, single-digit numbers are spelled out (when not used in measurements).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sentence was taken from the same article, it should be identical on both places.
@@ -28,6 +28,8 @@ System demos are typically held the week after a minor release becomes available | |||
|
|||
* It is now possibile to use custom logback.xml in all API ML services. Configuration for separate services can be performed by adding logging.config parameter under each API ML component in Zowe YAML file. ([#3669](https://github.com/zowe/api-layer/issues/3669)) | |||
|
|||
* While migrating from Zowe v2.18, if you are using keyrings, verify that Zowe YAML references to `safkeyring` use 2 slashes, not 4, such as `safkeyring://` instead of `safkeyring:////`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should spell out 2 and 4. Typically, single-digit numbers are spelled out (when not used in measurements).
- To tighten up this sentence, I would include the examples in parentheses after the slash counts: " ... use two forward slashes (
safkeyring://
), not four (safkeyring:////
).
Describe your pull request here:
The following is mentioned:
While migrating from Zowe v2.18, if you are using keyrings, verify that Zowe YAML references to
safkeyring
use 2 slashes, not 4, such assafkeyring://
instead ofsafkeyring:////
List the file(s) included in this PR:
After creating the PR, follow the instructions in the comments.